Search in sources :

Example 16 with TrackerValidationReport

use of org.hisp.dhis.tracker.report.TrackerValidationReport in project dhis2-core by dhis2.

the class DefaultTrackerValidationServiceTest method removeOnErrorHookPreventsFurtherValidationOfInvalidEntityEvenInFullValidationMode.

@Test
void removeOnErrorHookPreventsFurtherValidationOfInvalidEntityEvenInFullValidationMode() {
    // Test shows
    // 1. Hooks with removeOnError==true remove invalid entities from the
    // TrackerBundle to prevent
    // subsequent hooks from validating it
    // 2. the TrackerBundle is mutated to only contain valid DTOs after
    // validation
    // 
    // Currently, the bundle is mutated by
    // 1. AbstractTrackerDtoValidationHook removes invalid DTOs if the hook
    // has removeOnError == true
    // 2. DefaultTrackerValidationService removes invalid DTOs if they were
    // not previously removed
    // by AbstractTrackerDtoValidationHook i.e. hooks having removeOnError
    // == false
    Event validEvent = event();
    Event invalidEvent = event();
    TrackerBundle bundle = newBundle().events(events(invalidEvent, validEvent)).build();
    ValidationHook removeOnError = ValidationHook.builder().removeOnError(true).validateEvent((reporter, event) -> reporter.addErrorIf(() -> invalidEvent.equals(event), event, TrackerErrorCode.E1032)).build();
    // using default AbstractTrackerDtoValidationHook behavior of
    // removeOnError==false
    ValidationHook doNotRemoveOnError = ValidationHook.builder().validateEvent((reporter, event) -> reporter.addErrorIf(() -> invalidEvent.equals(event), event, TrackerErrorCode.E9999)).build();
    service = new DefaultTrackerValidationService(List.of(removeOnError, doNotRemoveOnError), Collections.emptyList());
    TrackerValidationReport report = service.validate(bundle);
    assertTrue(report.hasErrors());
    assertEquals(1, report.getErrors().size(), "only remove on error hook should add 1 error");
    assertHasError(report, TrackerErrorCode.E1032, invalidEvent);
    assertFalse(bundle.getEvents().contains(invalidEvent));
    assertTrue(bundle.getEvents().contains(validEvent));
}
Also used : ArgumentMatchers.any(org.mockito.ArgumentMatchers.any) Arrays(java.util.Arrays) ValidationErrorReporter(org.hisp.dhis.tracker.report.ValidationErrorReporter) Mockito.verifyNoInteractions(org.mockito.Mockito.verifyNoInteractions) ArrayList(java.util.ArrayList) Enrollment(org.hisp.dhis.tracker.domain.Enrollment) Assertions.assertFalse(org.junit.jupiter.api.Assertions.assertFalse) AssertTrackerValidationReport.assertHasWarning(org.hisp.dhis.tracker.validation.hooks.AssertTrackerValidationReport.assertHasWarning) BiConsumer(java.util.function.BiConsumer) User(org.hisp.dhis.user.User) Assertions.assertEquals(org.junit.jupiter.api.Assertions.assertEquals) Event(org.hisp.dhis.tracker.domain.Event) TrackedEntity(org.hisp.dhis.tracker.domain.TrackedEntity) Mockito.times(org.mockito.Mockito.times) Mockito.when(org.mockito.Mockito.when) ValidationMode(org.hisp.dhis.tracker.ValidationMode) TrackerBundle(org.hisp.dhis.tracker.bundle.TrackerBundle) AbstractTrackerDtoValidationHook(org.hisp.dhis.tracker.validation.hooks.AbstractTrackerDtoValidationHook) Mockito.verify(org.mockito.Mockito.verify) TrackerErrorCode(org.hisp.dhis.tracker.report.TrackerErrorCode) Objects(java.util.Objects) Test(org.junit.jupiter.api.Test) List(java.util.List) Builder(lombok.Builder) Assertions.assertTrue(org.junit.jupiter.api.Assertions.assertTrue) TrackerImportStrategy(org.hisp.dhis.tracker.TrackerImportStrategy) TrackerValidationReport(org.hisp.dhis.tracker.report.TrackerValidationReport) AssertTrackerValidationReport.assertHasError(org.hisp.dhis.tracker.validation.hooks.AssertTrackerValidationReport.assertHasError) CodeGenerator(org.hisp.dhis.common.CodeGenerator) NotNull(org.jetbrains.annotations.NotNull) Collections(java.util.Collections) Mockito.mock(org.mockito.Mockito.mock) TrackerValidationReport(org.hisp.dhis.tracker.report.TrackerValidationReport) Event(org.hisp.dhis.tracker.domain.Event) TrackerBundle(org.hisp.dhis.tracker.bundle.TrackerBundle) AbstractTrackerDtoValidationHook(org.hisp.dhis.tracker.validation.hooks.AbstractTrackerDtoValidationHook) Test(org.junit.jupiter.api.Test)

Example 17 with TrackerValidationReport

use of org.hisp.dhis.tracker.report.TrackerValidationReport in project dhis2-core by dhis2.

the class DefaultTrackerValidationServiceTest method childEntitiesOfInvalidParentsAreStillValidated.

@Test
void childEntitiesOfInvalidParentsAreStillValidated() {
    // Test shows
    // the children of a tracked entity will still be validated even if it
    // as a parent is invalid
    TrackedEntity invalidTrackedEntity = trackedEntity();
    Enrollment invalidEnrollment = enrollment();
    invalidTrackedEntity.setEnrollments(enrollments(invalidEnrollment));
    Event invalidEvent = event();
    invalidEnrollment.setEvents(events(invalidEvent));
    TrackerBundle bundle = newBundle().validationMode(ValidationMode.FULL).trackedEntities(trackedEntities(invalidTrackedEntity)).enrollments(invalidTrackedEntity.getEnrollments()).events(invalidEnrollment.getEvents()).build();
    ValidationHook hook = ValidationHook.builder().validateTrackedEntity((reporter, te) -> reporter.addErrorIf(() -> invalidTrackedEntity.equals(te), te, TrackerErrorCode.E1090)).validateEnrollment((reporter, enrollment) -> reporter.addErrorIf(() -> invalidEnrollment.equals(enrollment), enrollment, TrackerErrorCode.E1069)).validateEvent((reporter, event) -> reporter.addErrorIf(() -> invalidEvent.equals(event), event, TrackerErrorCode.E1032)).build();
    service = new DefaultTrackerValidationService(List.of(hook), Collections.emptyList());
    TrackerValidationReport report = service.validate(bundle);
    assertTrue(report.hasErrors());
    assertEquals(3, report.getErrors().size());
    assertHasError(report, TrackerErrorCode.E1090, invalidTrackedEntity);
    assertHasError(report, TrackerErrorCode.E1069, invalidEnrollment);
    assertHasError(report, TrackerErrorCode.E1032, invalidEvent);
    assertTrue(bundle.getTrackedEntities().isEmpty());
    assertTrue(bundle.getEnrollments().isEmpty());
    assertTrue(bundle.getEvents().isEmpty());
}
Also used : ArgumentMatchers.any(org.mockito.ArgumentMatchers.any) Arrays(java.util.Arrays) ValidationErrorReporter(org.hisp.dhis.tracker.report.ValidationErrorReporter) Mockito.verifyNoInteractions(org.mockito.Mockito.verifyNoInteractions) ArrayList(java.util.ArrayList) Enrollment(org.hisp.dhis.tracker.domain.Enrollment) Assertions.assertFalse(org.junit.jupiter.api.Assertions.assertFalse) AssertTrackerValidationReport.assertHasWarning(org.hisp.dhis.tracker.validation.hooks.AssertTrackerValidationReport.assertHasWarning) BiConsumer(java.util.function.BiConsumer) User(org.hisp.dhis.user.User) Assertions.assertEquals(org.junit.jupiter.api.Assertions.assertEquals) Event(org.hisp.dhis.tracker.domain.Event) TrackedEntity(org.hisp.dhis.tracker.domain.TrackedEntity) Mockito.times(org.mockito.Mockito.times) Mockito.when(org.mockito.Mockito.when) ValidationMode(org.hisp.dhis.tracker.ValidationMode) TrackerBundle(org.hisp.dhis.tracker.bundle.TrackerBundle) AbstractTrackerDtoValidationHook(org.hisp.dhis.tracker.validation.hooks.AbstractTrackerDtoValidationHook) Mockito.verify(org.mockito.Mockito.verify) TrackerErrorCode(org.hisp.dhis.tracker.report.TrackerErrorCode) Objects(java.util.Objects) Test(org.junit.jupiter.api.Test) List(java.util.List) Builder(lombok.Builder) Assertions.assertTrue(org.junit.jupiter.api.Assertions.assertTrue) TrackerImportStrategy(org.hisp.dhis.tracker.TrackerImportStrategy) TrackerValidationReport(org.hisp.dhis.tracker.report.TrackerValidationReport) AssertTrackerValidationReport.assertHasError(org.hisp.dhis.tracker.validation.hooks.AssertTrackerValidationReport.assertHasError) CodeGenerator(org.hisp.dhis.common.CodeGenerator) NotNull(org.jetbrains.annotations.NotNull) Collections(java.util.Collections) Mockito.mock(org.mockito.Mockito.mock) TrackerValidationReport(org.hisp.dhis.tracker.report.TrackerValidationReport) TrackedEntity(org.hisp.dhis.tracker.domain.TrackedEntity) Enrollment(org.hisp.dhis.tracker.domain.Enrollment) Event(org.hisp.dhis.tracker.domain.Event) TrackerBundle(org.hisp.dhis.tracker.bundle.TrackerBundle) AbstractTrackerDtoValidationHook(org.hisp.dhis.tracker.validation.hooks.AbstractTrackerDtoValidationHook) Test(org.junit.jupiter.api.Test)

Example 18 with TrackerValidationReport

use of org.hisp.dhis.tracker.report.TrackerValidationReport in project dhis2-core by dhis2.

the class DefaultTrackerValidationServiceConfigOrderTest method hooksAreExecutedInTrackerValidationConfigOrder.

@Test
void hooksAreExecutedInTrackerValidationConfigOrder() {
    // Test that hooks declared in TrackerValidationConfig validationHooks()
    // are injected
    // into the TrackerValidationService. This is important since order
    // matters in the current implementation.
    // Note that FAIL_FAST shows that although the event is also invalid due
    // to not having an orgUnit and more it
    // fails due to the first failed check which is the
    // PreCheckUidValidationHook
    Event event = new Event();
    event.setEvent("invalidUid");
    TrackerBundle bundle = TrackerBundle.builder().importMode(TrackerBundleMode.VALIDATE).validationMode(ValidationMode.FAIL_FAST).skipRuleEngine(true).events(Collections.singletonList(event)).build();
    TrackerValidationReport report = trackerValidationService.validate(bundle);
    assertTrue(report.hasErrors());
    assertEquals(1, report.getErrors().size());
    assertEquals(E1048, report.getErrors().get(0).getErrorCode());
}
Also used : TrackerValidationReport(org.hisp.dhis.tracker.report.TrackerValidationReport) Event(org.hisp.dhis.tracker.domain.Event) TrackerBundle(org.hisp.dhis.tracker.bundle.TrackerBundle) Test(org.junit.jupiter.api.Test) DhisSpringTest(org.hisp.dhis.DhisSpringTest)

Aggregations

TrackerValidationReport (org.hisp.dhis.tracker.report.TrackerValidationReport)18 Test (org.junit.jupiter.api.Test)11 TrackerBundle (org.hisp.dhis.tracker.bundle.TrackerBundle)10 Event (org.hisp.dhis.tracker.domain.Event)10 User (org.hisp.dhis.user.User)10 ArrayList (java.util.ArrayList)9 ValidationErrorReporter (org.hisp.dhis.tracker.report.ValidationErrorReporter)9 Arrays (java.util.Arrays)8 Collections (java.util.Collections)8 List (java.util.List)8 Objects (java.util.Objects)8 BiConsumer (java.util.function.BiConsumer)8 Builder (lombok.Builder)8 CodeGenerator (org.hisp.dhis.common.CodeGenerator)8 TrackerImportStrategy (org.hisp.dhis.tracker.TrackerImportStrategy)8 ValidationMode (org.hisp.dhis.tracker.ValidationMode)8 Enrollment (org.hisp.dhis.tracker.domain.Enrollment)8 TrackedEntity (org.hisp.dhis.tracker.domain.TrackedEntity)8 TrackerErrorCode (org.hisp.dhis.tracker.report.TrackerErrorCode)8 AbstractTrackerDtoValidationHook (org.hisp.dhis.tracker.validation.hooks.AbstractTrackerDtoValidationHook)8