use of org.ovirt.engine.core.common.businessentities.VmTemplate in project ovirt-engine by oVirt.
the class TemplateListModelTest method testBuildTemplateOnSave.
@Test
public void testBuildTemplateOnSave() {
VmTemplate template = new VmTemplate();
TemplateListModel.buildTemplateOnSave(model, template);
verifyBuiltTemplate(template);
}
use of org.ovirt.engine.core.common.businessentities.VmTemplate in project ovirt-engine by oVirt.
the class BaseVmListModelTest method setUpUnitVmModelExpectations.
protected void setUpUnitVmModelExpectations(UnitVmModel model) {
when(model.getVmType().getSelectedItem()).thenReturn(VM_TYPE);
VmTemplate template = new VmTemplate();
template.setId(TEMPLATE_GUID);
TemplateWithVersion templateWithVersion = mock(TemplateWithVersion.class);
when(templateWithVersion.getTemplateVersion()).thenReturn(template);
when(model.getTemplateWithVersion().getSelectedItem()).thenReturn(templateWithVersion);
when(model.getName().getEntity()).thenReturn(VM_NAME);
InstanceType instanceType = new VmTemplate();
instanceType.setId(INSTANCE_TYPE_ID);
when(model.getInstanceTypes().getSelectedItem()).thenReturn(instanceType);
when(model.getOSType().getSelectedItem()).thenReturn(OS_TYPE);
when(model.getNumOfMonitors().getSelectedItem()).thenReturn(NUM_OF_MONITORS);
when(model.getDescription().getEntity()).thenReturn(DESCRIPTION);
when(model.getComment().getEntity()).thenReturn(COMMENT);
when(model.getEmulatedMachine().getSelectedItem()).thenReturn(EMULATED_MACHINE);
when(model.getCustomCpu().getSelectedItem()).thenReturn(CUSTOM_CPU_NAME);
when(model.getMemSize().getEntity()).thenReturn(MEM_SIZE);
when(model.getMaxMemorySize().getEntity()).thenReturn(MAX_MEMORY_SIZE);
when(model.getMinAllocatedMemory().getEntity()).thenReturn(MIN_MEM);
when(model.getSelectedCluster().getId()).thenReturn(CLUSTER_ID);
ListModel<TimeZoneModel> timeZoneModelListModel = mockTimeZoneListModel();
when(model.getTimeZone()).thenReturn(timeZoneModelListModel);
when(model.getNumOfSockets().getSelectedItem()).thenReturn(NUM_OF_SOCKETS);
when(model.getCoresPerSocket().getSelectedItem()).thenReturn(CORES_PER_SOCKET);
when(model.getThreadsPerCore().getSelectedItem()).thenReturn(THREADS_PER_CORE);
SerialNumberPolicyModel serialNumberPolicyModel = mockSerialNumberPolicyModel();
when(model.getSerialNumberPolicy()).thenReturn(serialNumberPolicyModel);
when(model.getAllowConsoleReconnect().getEntity()).thenReturn(true);
when(model.getIsSingleQxlEnabled().getEntity()).thenReturn(true);
when(model.getTotalCPUCores().getEntity()).thenReturn(Integer.toString(TOTAL_CPU));
when(model.getUsbPolicy().getSelectedItem()).thenReturn(USB_POLICY);
when(model.getIsStateless().getEntity()).thenReturn(true);
when(model.getIsSmartcardEnabled().getEntity()).thenReturn(true);
when(model.getIsDeleteProtected().getEntity()).thenReturn(true);
when(model.extractSelectedSsoMethod()).thenReturn(SSO_METHOD);
when(model.getBootSequence()).thenReturn(BOOT_SEQUENCE);
ListModel<RepoImage> cdListModel = mockCdListModel();
when(model.getCdImage()).thenReturn(cdListModel);
when(model.getIsHighlyAvailable().getEntity()).thenReturn(true);
when(model.getInitrd_path().getEntity()).thenReturn(INITRD_PATH);
when(model.getKernel_path().getEntity()).thenReturn(KERNEL_PATH);
when(model.getKernel_parameters().getEntity()).thenReturn(KERNEL_PARAMS);
when(model.getCustomPropertySheet().serialize()).thenReturn(CUSTOM_PROPERTIES);
ListModel<Quota> quotaListModel = mockQuotaListModel();
when(model.getQuota()).thenReturn(quotaListModel);
when(model.getVncKeyboardLayout().getSelectedItem()).thenReturn(VNC_KEYBOARD_LAYOUT);
when(model.getDisplayType().getSelectedItem()).thenReturn(DISPLAY_TYPE);
EntityModel<Integer> priorityEntityModel = mockEntityModel(PRIORITY);
when(model.getPriority().getSelectedItem()).thenReturn(priorityEntityModel);
when(model.getIsRunAndPause().getEntity()).thenReturn(true);
VDS defaultHost = new VDS();
defaultHost.setId(HOST_ID);
when(model.getDefaultHost().getSelectedItem()).thenReturn(defaultHost);
when(model.getDefaultHost().getSelectedItems()).thenReturn(Collections.singletonList(defaultHost));
when(model.getIsAutoAssign().getEntity()).thenReturn(false);
when(model.getMigrationMode().getSelectedItem()).thenReturn(MIGRATION_SUPPORT);
when(model.getSelectedMigrationDowntime()).thenReturn(MIGRATION_DOWNTIME);
when(model.getBootMenuEnabled().getEntity()).thenReturn(true);
when(model.getSpiceFileTransferEnabled().getEntity()).thenReturn(true);
when(model.getSpiceCopyPasteEnabled().getEntity()).thenReturn(true);
ListModel<CpuProfile> cpuProfiles = mockCpuProfiles();
when(model.getCpuProfiles()).thenReturn(cpuProfiles);
when(model.getNumaNodeCount().getEntity()).thenReturn(0);
when(model.getNumaTuneMode().getSelectedItem()).thenReturn(NumaTuneMode.INTERLEAVE);
when(model.getAutoConverge().getSelectedItem()).thenReturn(true);
when(model.getMigrateCompressed().getSelectedItem()).thenReturn(true);
when(model.getIcon().getEntity()).thenReturn(new IconWithOsDefault(LARGE_ICON_DATA, LARGE_OS_DEFAULT_ICON_DATA, SMALL_ICON_ID, ValidationResult.ok()));
when(model.getIoThreadsEnabled().getEntity()).thenReturn(true);
when(model.getConsoleDisconnectAction().getSelectedItem()).thenReturn(ConsoleDisconnectAction.REBOOT);
when(model.getCustomCompatibilityVersion().getSelectedItem()).thenReturn(Version.v3_6);
when(model.getOverrideMigrationPolicy().getEntity()).thenReturn(false);
when(model.getLease().getSelectedItem()).thenReturn(null);
}
use of org.ovirt.engine.core.common.businessentities.VmTemplate in project ovirt-engine by oVirt.
the class UpdateVmCommand method validate.
@Override
protected boolean validate() {
if (!super.validate()) {
return false;
}
VM vmFromDB = getVm();
VM vmFromParams = getParameters().getVm();
if (Math.abs(vmFromDB.getVmCreationDate().getTime() - vmFromParams.getVmCreationDate().getTime()) > 1000) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_INVALID_CREATION_DATE);
}
vmFromParams.setVmCreationDate(vmFromDB.getVmCreationDate());
// check if VM was changed to use latest
if (vmFromDB.isUseLatestVersion() != vmFromParams.isUseLatestVersion() && vmFromParams.isUseLatestVersion()) {
// check if a version change is actually required or just let the local command to update this field
vmFromParams.setVmtGuid(vmTemplateDao.getTemplateWithLatestVersionInChain(getVm().getVmtGuid()).getId());
}
// It is not allowed to edit hosted engine VM until it is imported to the engine properly
if (vmFromDB.isHostedEngine() && !vmFromDB.isManagedHostedEngine()) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_UNMANAGED_HOSTED_ENGINE);
}
// pool VMs are allowed to change template id, this verifies that the change is only between template versions.
if (!vmFromDB.getVmtGuid().equals(vmFromParams.getVmtGuid())) {
VmTemplate origTemplate = vmTemplateDao.get(vmFromDB.getVmtGuid());
VmTemplate newTemplate = vmTemplateDao.get(vmFromParams.getVmtGuid());
if (newTemplate == null) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_TEMPLATE_DOES_NOT_EXIST);
} else if (origTemplate != null && !origTemplate.getBaseTemplateId().equals(newTemplate.getBaseTemplateId())) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_TEMPLATE_IS_ON_DIFFERENT_CHAIN);
} else if (vmFromDB.getVmPoolId() != null) {
isUpdateVmTemplateVersion = true;
// no more tests are needed because no more changes are allowed in this state
return true;
} else {
// template id can be changed for pool VMs only
return failValidation(EngineMessage.ACTION_TYPE_FAILED_TEMPLATE_ID_CANT_BE_CHANGED);
}
}
if (getCluster() == null) {
addValidationMessage(EngineMessage.ACTION_TYPE_FAILED_CLUSTER_CAN_NOT_BE_EMPTY);
return false;
}
if (vmFromDB.getClusterId() == null) {
failValidation(EngineMessage.ACTION_TYPE_FAILED_CLUSTER_CAN_NOT_BE_EMPTY);
return false;
}
if (!isVmExist()) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_VM_NOT_FOUND);
}
if (!canRunActionOnNonManagedVm()) {
return false;
}
if (StringUtils.isEmpty(vmFromParams.getName())) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_NAME_MAY_NOT_BE_EMPTY);
}
// check that VM name is not too long
boolean vmNameValidLength = isVmNameValidLength(vmFromParams);
if (!vmNameValidLength) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_NAME_LENGTH_IS_TOO_LONG);
}
// Checking if a desktop with same name already exists
if (!StringUtils.equals(vmFromDB.getName(), vmFromParams.getName())) {
boolean exists = isVmWithSameNameExists(vmFromParams.getName(), getStoragePoolId());
if (exists) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_NAME_ALREADY_USED);
}
}
Version customCompatibilityVersionFromParams = vmFromParams.getStaticData().getCustomCompatibilityVersion();
if (customCompatibilityVersionFromParams != null && !isCompatibilityVersionSupportedByCluster(customCompatibilityVersionFromParams)) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_CUSTOM_COMPATIBILITY_VERSION_NOT_SUPPORTED, String.format("$Ccv %s", customCompatibilityVersionFromParams));
}
if (vmFromParams.getVmType() == VmType.HighPerformance && !FeatureSupported.isHighPerformanceTypeSupported(getEffectiveCompatibilityVersion())) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_HIGH_PERFORMANCE_IS_NOT_SUPPORTED, String.format("$Version %s", getEffectiveCompatibilityVersion()));
}
if (!validateCustomProperties(vmFromParams.getStaticData())) {
return false;
}
if (!validate(vmHandler.isOsTypeSupported(vmFromParams.getOs(), getCluster().getArchitecture()))) {
return false;
}
if (!validate(vmHandler.isCpuSupported(vmFromParams.getVmOsId(), getEffectiveCompatibilityVersion(), getCluster().getCpuName()))) {
return false;
}
if (getParameters().getVmStaticData().getDefaultDisplayType() != DisplayType.none && vmFromParams.getSingleQxlPci() && !validate(vmHandler.isSingleQxlDeviceLegal(vmFromParams.getDefaultDisplayType(), vmFromParams.getOs()))) {
return false;
}
if (!validate(vmHandler.validateSmartCardDevice(getParameters().getVmStaticData()))) {
return false;
}
if (vmFromParams.isAutoStartup() && vmFromDB.isHostedEngine()) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_VM_CANNOT_BE_HIGHLY_AVAILABLE_AND_HOSTED_ENGINE);
}
if (vmFromParams.getVmType() == VmType.HighPerformance && vmFromDB.isHostedEngine()) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_VM_CANNOT_BE_HIGH_PERFORMANCE_AND_HOSTED_ENGINE);
}
if (!areUpdatedFieldsLegal()) {
return failValidation(vmFromDB.isHostedEngine() ? EngineMessage.VM_CANNOT_UPDATE_HOSTED_ENGINE_FIELD : EngineMessage.VM_CANNOT_UPDATE_ILLEGAL_FIELD);
}
if (!vmFromDB.getClusterId().equals(vmFromParams.getClusterId())) {
return failValidation(EngineMessage.VM_CANNOT_UPDATE_CLUSTER);
}
if (!isDedicatedVdsExistOnSameCluster(vmFromParams.getStaticData())) {
return false;
}
// Check if number of monitors passed is legal
if (getParameters().getVmStaticData().getDefaultDisplayType() != DisplayType.none && !vmHandler.isNumOfMonitorsLegal(vmHandler.getResultingVmGraphics(getVmDeviceUtils().getGraphicsTypesOfEntity(getVmId()), getParameters().getGraphicsDevices()), getParameters().getVmStaticData().getNumOfMonitors()).isValid()) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_ILLEGAL_NUM_OF_MONITORS);
}
// Check PCI and IDE limits are ok
if (!isValidPciAndIdeLimit(vmFromParams)) {
return false;
}
if (!validate(vmHandler.isVmPriorityValueLegal(vmFromParams.getPriority()))) {
return false;
}
if (!validate(VmValidator.validateCpuSockets(vmFromParams.getStaticData(), getEffectiveCompatibilityVersion()))) {
return false;
}
// check for Vm Payload
if (getParameters().getVmPayload() != null) {
if (!checkPayload(getParameters().getVmPayload())) {
return false;
}
// we save the content in base64 string
for (Map.Entry<String, String> entry : getParameters().getVmPayload().getFiles().entrySet()) {
entry.setValue(new String(BASE_64.encode(entry.getValue().getBytes()), StandardCharsets.UTF_8));
}
}
// check for Vm Watchdog Model
if (getParameters().getWatchdog() != null) {
if (!validate(new VmWatchdogValidator(vmFromParams.getOs(), getParameters().getWatchdog(), getEffectiveCompatibilityVersion()).isValid())) {
return false;
}
}
// Check if the graphics and display from parameters are supported
if (!validate(vmHandler.isGraphicsAndDisplaySupported(vmFromParams.getOs(), vmHandler.getResultingVmGraphics(getVmDeviceUtils().getGraphicsTypesOfEntity(getVmId()), getParameters().getGraphicsDevices()), vmFromParams.getDefaultDisplayType(), getEffectiveCompatibilityVersion()))) {
return false;
}
if (!FeatureSupported.isMigrationSupported(getCluster().getArchitecture(), getEffectiveCompatibilityVersion()) && vmFromParams.getMigrationSupport() != MigrationSupport.PINNED_TO_HOST) {
return failValidation(EngineMessage.VM_MIGRATION_IS_NOT_SUPPORTED);
}
// check cpuPinning
if (!validate(isCpuPinningValid(vmFromParams.getCpuPinning(), vmFromParams.getStaticData()))) {
return false;
}
if (!validatePinningAndMigration()) {
return false;
}
if (vmFromParams.isUseHostCpuFlags() && vmFromParams.getMigrationSupport() != MigrationSupport.PINNED_TO_HOST) {
return failValidation(EngineMessage.VM_HOSTCPU_MUST_BE_PINNED_TO_HOST);
}
if (!isCpuSharesValid(vmFromParams)) {
return failValidation(EngineMessage.QOS_CPU_SHARES_OUT_OF_RANGE);
}
if (!VmCpuCountHelper.validateCpuCounts(vmFromParams)) {
return failValidation(EngineMessage.TOO_MANY_CPU_COMPONENTS);
}
if (vmFromParams.isUseHostCpuFlags() && (ArchitectureType.ppc == getCluster().getArchitecture().getFamily())) {
return failValidation(EngineMessage.USE_HOST_CPU_REQUESTED_ON_UNSUPPORTED_ARCH);
}
if (!validateCPUHotplug(getParameters().getVmStaticData())) {
return failValidation(EngineMessage.CPU_HOTPLUG_TOPOLOGY_INVALID);
}
if (!validateMemoryAlignment(getParameters().getVmStaticData())) {
return false;
}
if (isVirtioScsiEnabled()) {
// Verify OS compatibility
if (!validate(vmHandler.isOsTypeSupportedForVirtioScsi(vmFromParams.getOs(), getEffectiveCompatibilityVersion()))) {
return false;
}
}
VmValidator vmValidator = createVmValidator(vmFromParams);
// A pinned VM, must run on one of its hosts
if (!validate(vmValidator.isPinnedVmRunningOnDedicatedHost(vmFromDB, vmFromParams.getStaticData()))) {
return false;
}
if (Boolean.FALSE.equals(getParameters().isVirtioScsiEnabled()) && !validate(vmValidator.canDisableVirtioScsi(null))) {
return false;
}
if (vmFromParams.getMinAllocatedMem() > vmFromParams.getMemSizeMb()) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_MIN_MEMORY_CANNOT_EXCEED_MEMORY_SIZE);
}
if (vmFromParams.getCpuProfileId() == null || !Objects.equals(vmFromDB.getCpuProfileId(), vmFromParams.getCpuProfileId())) {
if (!setAndValidateCpuProfile()) {
return false;
}
}
if (isBalloonEnabled() && !osRepository.isBalloonEnabled(getParameters().getVmStaticData().getOsId(), getEffectiveCompatibilityVersion())) {
addValidationMessageVariable("clusterArch", getCluster().getArchitecture());
return failValidation(EngineMessage.BALLOON_REQUESTED_ON_NOT_SUPPORTED_ARCH);
}
if (isSoundDeviceEnabled() && !osRepository.isSoundDeviceEnabled(getParameters().getVmStaticData().getOsId(), getEffectiveCompatibilityVersion())) {
addValidationMessageVariable("clusterArch", getCluster().getArchitecture());
return failValidation(EngineMessage.SOUND_DEVICE_REQUESTED_ON_NOT_SUPPORTED_ARCH);
}
if (!validate(getNumaValidator().checkVmNumaNodesIntegrity(getParameters().getVm(), getParameters().getVm().getvNumaNodeList()))) {
return false;
}
if (getParameters().getVmLargeIcon() != null && !validate(IconValidator.validate(IconValidator.DimensionsType.LARGE_CUSTOM_ICON, getParameters().getVmLargeIcon()))) {
return false;
}
if (getParameters().getVmStaticData() != null && getParameters().getVmStaticData().getSmallIconId() != null && // icon id is ignored if large icon is sent
getParameters().getVmLargeIcon() == null && !validate(IconValidator.validateIconId(getParameters().getVmStaticData().getSmallIconId(), "Small"))) {
return false;
}
if (getParameters().getVmStaticData() != null && getParameters().getVmStaticData().getLargeIconId() != null && // icon id is ignored if large icon is sent
getParameters().getVmLargeIcon() == null && !validate(IconValidator.validateIconId(getParameters().getVmStaticData().getLargeIconId(), "Large"))) {
return false;
}
if (vmFromParams.getProviderId() != null) {
Provider<?> provider = providerDao.get(vmFromParams.getProviderId());
if (provider == null) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_PROVIDER_DOESNT_EXIST);
}
if (provider.getType() != ProviderType.FOREMAN) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_HOST_PROVIDER_TYPE_MISMATCH);
}
}
if (getCluster().isInUpgradeMode()) {
getParameters().getVm().setClusterCompatibilityVersion(getCluster().getCompatibilityVersion());
if (!validate(getClusterUpgradeValidator().isVmReadyForUpgrade(getParameters().getVm()))) {
return false;
}
}
if (!validateQuota(getParameters().getVmStaticData().getQuotaId())) {
return false;
}
if (!validate(vmHandler.validateMaxMemorySize(getParameters().getVmStaticData(), getEffectiveCompatibilityVersion()))) {
return false;
}
if (shouldAddLease(getParameters().getVmStaticData())) {
if (!canAddLease()) {
return false;
}
if (!getVm().isDown() && getParameters().getVmStaticData().getLeaseStorageDomainId() != null && getVm().getLeaseStorageDomainId() != null) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_HOT_SWAPPING_VM_LEASES_NOT_SUPPORTED);
}
}
List<EngineMessage> msgs = openStackMetadataAdapter.validate(getParameters().getVmStaticData().getVmInit());
if (!CollectionUtils.isEmpty(msgs)) {
return failValidation(msgs);
}
final boolean isMemoryHotUnplug = vmFromDB.getMemSizeMb() > vmFromParams.getMemSizeMb() && isHotSetEnabled() && getParameters().isMemoryHotUnplugEnabled();
if (isMemoryHotUnplug && !FeatureSupported.hotUnplugMemory(getVm().getCompatibilityVersion(), getVm().getClusterArch())) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_MEMORY_HOT_UNPLUG_NOT_SUPPORTED_FOR_COMPAT_VERSION_AND_ARCH, ReplacementUtils.createSetVariableString("compatibilityVersion", getVm().getCompatibilityVersion()), ReplacementUtils.createSetVariableString("architecture", getVm().getClusterArch()));
}
if (vmFromDB.getMemSizeMb() != vmFromParams.getMemSizeMb() && vmFromDB.isRunning() && isHotSetEnabled() && HugePageUtils.isBackedByHugepages(vmFromDB.getStaticData()) && (vmFromDB.getMemSizeMb() < vmFromParams.getMemSizeMb() || (vmFromDB.getMemSizeMb() > vmFromParams.getMemSizeMb() && getParameters().isMemoryHotUnplugEnabled()))) {
return failValidation(EngineMessage.ACTION_TYPE_FAILED_MEMORY_HOT_SET_NOT_SUPPORTED_FOR_HUGE_PAGES);
}
return true;
}
use of org.ovirt.engine.core.common.businessentities.VmTemplate in project ovirt-engine by oVirt.
the class UpdateClusterCommand method updateTemplates.
private boolean updateTemplates() {
for (VmTemplate template : templatesLockedForUpdate) {
// the object was loaded in before command execution started and thus the value may be outdated
template.setClusterCompatibilityVersion(getCluster().getCompatibilityVersion());
UpdateVmTemplateParameters parameters = new UpdateVmTemplateParameters(template);
// Locking by UpdateVmTemplate is disabled since templates are already locked in #getExclusiveLocks method.
parameters.setLockProperties(LockProperties.create(LockProperties.Scope.None));
parameters.setClusterLevelChangeFromVersion(oldCluster.getCompatibilityVersion());
updateRngDeviceIfNecessary(template.getId(), template.getCustomCompatibilityVersion(), parameters);
updateResumeBehavior(template);
final ActionReturnValue result = runInternalAction(ActionType.UpdateVmTemplate, parameters, cloneContextAndDetachFromParent());
if (!result.getSucceeded()) {
List<String> params = new ArrayList<>();
params.add("$action Update");
params.add("$type Template");
params.add(parseErrorMessage(result.getValidationMessages()));
List<String> messages = Backend.getInstance().getErrorsTranslator().translateErrorText(params);
failedUpgradeEntities.put(template.getName(), getFailedMessage(messages));
}
}
return true;
}
use of org.ovirt.engine.core.common.businessentities.VmTemplate in project ovirt-engine by oVirt.
the class RemoveGraphicsAndVideoDevicesCommand method setTemplateToHeadlessMode.
private void setTemplateToHeadlessMode() {
VmTemplate vmTemplate = vmTemplateDao.get(getVmBaseId());
if (vmTemplate != null && vmTemplate.getDefaultDisplayType() != DisplayType.none) {
vmTemplate.setDefaultDisplayType(DisplayType.none);
vmTemplate.setSingleQxlPci(false);
vmTemplateDao.update(vmTemplate);
}
}
Aggregations