use of teammates.common.datatransfer.attributes.StudentProfileAttributes in project teammates by TEAMMATES.
the class AccountsDb method updateAccount.
/**
* Preconditions:
* <br> * {@code accountToAdd} is not null and has valid data.
*/
public void updateAccount(AccountAttributes a, boolean updateStudentProfile) throws InvalidParametersException, EntityDoesNotExistException {
Assumption.assertNotNull(Const.StatusCodes.DBLEVEL_NULL_INPUT, a);
if (!a.isValid()) {
throw new InvalidParametersException(a.getInvalidityInfo());
}
Account accountToUpdate = getAccountEntity(a.googleId, updateStudentProfile);
if (accountToUpdate == null) {
throw new EntityDoesNotExistException(ERROR_UPDATE_NON_EXISTENT_ACCOUNT + a.googleId + ThreadHelper.getCurrentThreadStack());
}
a.sanitizeForSaving();
accountToUpdate.setName(a.name);
accountToUpdate.setEmail(a.email);
accountToUpdate.setIsInstructor(a.isInstructor);
accountToUpdate.setInstitute(a.institute);
if (updateStudentProfile) {
StudentProfile existingProfile = accountToUpdate.getStudentProfile();
if (existingProfile == null) {
existingProfile = new StudentProfile(a.studentProfile.googleId);
}
StudentProfileAttributes existingProfileAttributes = StudentProfileAttributes.valueOf(existingProfile);
a.studentProfile.modifiedDate = existingProfileAttributes.modifiedDate;
// this is to maintain integrity of the modified date.
if (!existingProfileAttributes.toString().equals(a.studentProfile.toString())) {
StudentProfile updatedProfile = a.studentProfile.toEntity();
accountToUpdate.setStudentProfile(updatedProfile);
profilesDb.saveEntity(updatedProfile);
}
}
saveEntity(accountToUpdate, a);
}
use of teammates.common.datatransfer.attributes.StudentProfileAttributes in project teammates by TEAMMATES.
the class AccountsDb method createEntitiesDeferred.
@Override
public List<Account> createEntitiesDeferred(Collection<AccountAttributes> accountsToAdd) throws InvalidParametersException {
List<StudentProfileAttributes> profilesToAdd = new LinkedList<>();
for (AccountAttributes accountToAdd : accountsToAdd) {
profilesToAdd.add(accountToAdd.studentProfile);
}
profilesDb.createEntitiesDeferred(profilesToAdd);
return super.createEntitiesDeferred(accountsToAdd);
}
use of teammates.common.datatransfer.attributes.StudentProfileAttributes in project teammates by TEAMMATES.
the class ProfilesDb method deleteEntities.
@Override
public void deleteEntities(Collection<StudentProfileAttributes> entitiesToDelete) {
Assumption.assertNotNull(Const.StatusCodes.DBLEVEL_NULL_INPUT, entitiesToDelete);
ArrayList<Key<StudentProfile>> keysToDelete = new ArrayList<>();
for (StudentProfileAttributes entityToDelete : entitiesToDelete) {
Key<StudentProfile> keyToDelete = getEntityQueryKeys(entityToDelete).first().now();
if (keyToDelete == null) {
keyToDelete = getEntityQueryKeysForLegacyData(entityToDelete).first().now();
}
if (keyToDelete == null) {
continue;
}
keysToDelete.add(keyToDelete);
log.info(entityToDelete.getBackupIdentifier());
}
ofy().delete().keys(keysToDelete).now();
}
use of teammates.common.datatransfer.attributes.StudentProfileAttributes in project teammates by TEAMMATES.
the class ProfilesLogicTest method testStudentProfileFunctions.
@Test
public void testStudentProfileFunctions() throws Exception {
// 4 functions are tested together as:
// => The functions are very simple (one-liners)
// => They are fundamentally related and easily tested together
// => It saves time during tests
______TS("get SP");
StudentProfileAttributes expectedSpa = StudentProfileAttributes.builder("id").withShortName("shortName").withEmail("personal@email.com").withInstitute("institute").withNationality("American").withGender("female").withMoreInfo("moreInfo").build();
AccountAttributes accountWithStudentProfile = AccountAttributes.builder().withGoogleId("id").withName("name").withEmail("test@email.come").withInstitute("dev").withIsInstructor(true).withStudentProfileAttributes(expectedSpa).build();
accountsLogic.createAccount(accountWithStudentProfile);
StudentProfileAttributes actualSpa = profilesLogic.getStudentProfile(accountWithStudentProfile.googleId);
expectedSpa.modifiedDate = actualSpa.modifiedDate;
assertEquals(expectedSpa.toString(), actualSpa.toString());
______TS("update SP");
expectedSpa.pictureKey = "non-empty";
accountWithStudentProfile.studentProfile.pictureKey = expectedSpa.pictureKey;
profilesLogic.updateStudentProfile(accountWithStudentProfile.studentProfile);
actualSpa = profilesLogic.getStudentProfile(accountWithStudentProfile.googleId);
expectedSpa.modifiedDate = actualSpa.modifiedDate;
assertEquals(expectedSpa.toString(), actualSpa.toString());
______TS("update picture");
expectedSpa.pictureKey = writeFileToGcs(expectedSpa.googleId, "src/test/resources/images/profile_pic.png");
profilesLogic.updateStudentProfilePicture(expectedSpa.googleId, expectedSpa.pictureKey);
actualSpa = profilesLogic.getStudentProfile(accountWithStudentProfile.googleId);
expectedSpa.modifiedDate = actualSpa.modifiedDate;
assertEquals(expectedSpa.toString(), actualSpa.toString());
______TS("delete profile picture");
profilesLogic.deleteStudentProfilePicture(expectedSpa.googleId);
assertFalse(doesFileExistInGcs(new BlobKey(expectedSpa.pictureKey)));
actualSpa = profilesLogic.getStudentProfile(accountWithStudentProfile.googleId);
expectedSpa.modifiedDate = actualSpa.modifiedDate;
expectedSpa.pictureKey = "";
assertEquals(expectedSpa.toString(), actualSpa.toString());
// remove the account that was created
accountsLogic.deleteAccountCascade("id");
}
use of teammates.common.datatransfer.attributes.StudentProfileAttributes in project teammates by TEAMMATES.
the class StudentsLogicTest method testEnrollStudents.
private void testEnrollStudents() throws Exception {
String instructorId = "instructorForEnrollTesting";
String courseIdForEnrollTest = "courseForEnrollTest";
String instructorEmail = "instructor@email.tmt";
StudentProfileAttributes profileAttributes = StudentProfileAttributes.builder(instructorId).withShortName("Ins1").withGender("male").build();
AccountAttributes accountToAdd = AccountAttributes.builder().withGoogleId(instructorId).withName("Instructor 1").withEmail(instructorEmail).withInstitute("TEAMMATES Test Institute 1").withIsInstructor(true).withStudentProfileAttributes(profileAttributes).build();
accountsLogic.createAccount(accountToAdd);
coursesLogic.createCourseAndInstructor(instructorId, courseIdForEnrollTest, "Course for Enroll Testing", "UTC");
FeedbackSessionsLogic fsLogic = FeedbackSessionsLogic.inst();
FeedbackSessionAttributes fsAttr = FeedbackSessionAttributes.builder("newFeedbackSessionName", courseIdForEnrollTest, instructorEmail).withInstructions(new Text("default instructions")).withCreatedTime(Instant.now()).withStartTime(TimeHelperExtension.getInstantHoursOffsetFromNow(2)).withEndTime(TimeHelperExtension.getInstantHoursOffsetFromNow(5)).withSessionVisibleFromTime(TimeHelperExtension.getInstantHoursOffsetFromNow(1)).withResultsVisibleFromTime(TimeHelperExtension.getInstantHoursOffsetFromNow(6)).withTimeZone(ZoneId.of("Asia/Singapore")).withGracePeriodMinutes(0).withFeedbackSessionType(FeedbackSessionType.PRIVATE).withOpeningEmailEnabled(false).withClosingEmailEnabled(false).withPublishedEmailEnabled(false).build();
fsLogic.createFeedbackSession(fsAttr);
______TS("all valid students, but contains blank lines and trailing spaces");
String headerLine = "team | name | email | comment";
String line0 = "t1 | n1 | e1@g | c1";
String line1 = " t2| n2| e2@g| c2";
String line2 = "\u00A0t3 |n3| e3@g|c3 ";
String line3 = "t4|n4| e4@g|c4";
String line4 = "t5| n5|e5@g |c5";
String lines = headerLine + System.lineSeparator() + line0 + System.lineSeparator() + line1 + System.lineSeparator() + line2 + System.lineSeparator() + " \t \t \t \t " + System.lineSeparator() + line3 + System.lineSeparator() + System.lineSeparator() + line4 + System.lineSeparator() + " " + System.lineSeparator() + System.lineSeparator();
CourseEnrollmentResult enrollResults = studentsLogic.enrollStudentsWithoutDocument(lines, courseIdForEnrollTest);
StudentAttributesFactory saf = new StudentAttributesFactory(headerLine);
assertEquals(5, enrollResults.studentList.size());
assertEquals(5, studentsLogic.getStudentsForCourse(courseIdForEnrollTest).size());
// Test enroll result
line0 = "t1|n1|e1@g|c1";
verifyEnrollmentResultForStudent(saf.makeStudent(line0, courseIdForEnrollTest), enrollResults.studentList.get(0), StudentUpdateStatus.NEW);
verifyEnrollmentResultForStudent(saf.makeStudent(line1, courseIdForEnrollTest), enrollResults.studentList.get(1), StudentUpdateStatus.NEW);
verifyEnrollmentResultForStudent(saf.makeStudent(line4, courseIdForEnrollTest), enrollResults.studentList.get(4), StudentUpdateStatus.NEW);
CourseDetailsBundle courseDetails = coursesLogic.getCourseSummary(courseIdForEnrollTest);
assertEquals(5, courseDetails.stats.unregisteredTotal);
______TS("includes a mix of unmodified, modified, and new");
String modifiedLine2 = "t3|modified name|e3@g|c3";
String line5 = "t6|n6|e6@g|c6";
lines = headerLine + System.lineSeparator() + line0 + System.lineSeparator() + modifiedLine2 + System.lineSeparator() + line1 + System.lineSeparator() + line5;
enrollResults = studentsLogic.enrollStudentsWithoutDocument(lines, courseIdForEnrollTest);
assertEquals(6, enrollResults.studentList.size());
assertEquals(6, studentsLogic.getStudentsForCourse(courseIdForEnrollTest).size());
verifyEnrollmentResultForStudent(saf.makeStudent(line0, courseIdForEnrollTest), enrollResults.studentList.get(0), StudentUpdateStatus.UNMODIFIED);
verifyEnrollmentResultForStudent(saf.makeStudent(modifiedLine2, courseIdForEnrollTest), enrollResults.studentList.get(1), StudentUpdateStatus.MODIFIED);
verifyEnrollmentResultForStudent(saf.makeStudent(line1, courseIdForEnrollTest), enrollResults.studentList.get(2), StudentUpdateStatus.UNMODIFIED);
verifyEnrollmentResultForStudent(saf.makeStudent(line5, courseIdForEnrollTest), enrollResults.studentList.get(3), StudentUpdateStatus.NEW);
assertEquals(StudentUpdateStatus.NOT_IN_ENROLL_LIST, enrollResults.studentList.get(4).updateStatus);
assertEquals(StudentUpdateStatus.NOT_IN_ENROLL_LIST, enrollResults.studentList.get(5).updateStatus);
______TS("includes an incorrect line");
// no changes should be done to the database
String incorrectLine = "incorrectly formatted line";
lines = headerLine + System.lineSeparator() + "t7|n7|e7@g|c7" + System.lineSeparator() + incorrectLine + System.lineSeparator() + line2 + System.lineSeparator() + line3;
try {
enrollResults = studentsLogic.enrollStudentsWithoutDocument(lines, courseIdForEnrollTest);
signalFailureToDetectException("Did not throw exception for incorrectly formatted line");
} catch (EnrollException e) {
assertTrue(e.getMessage().contains(incorrectLine));
}
assertEquals(6, studentsLogic.getStudentsForCourse(courseIdForEnrollTest).size());
______TS("null parameters");
try {
studentsLogic.enrollStudentsWithoutDocument("a|b|c|d", null);
signalFailureToDetectException();
} catch (AssertionError ae) {
assertEquals(Const.StatusCodes.DBLEVEL_NULL_INPUT, ae.getMessage());
}
______TS("same student added, modified and unmodified");
StudentProfileAttributes studentAttributes = StudentProfileAttributes.builder("tes.instructor").withShortName("Ins 1").withGender("male").build();
accountToAdd = AccountAttributes.builder().withGoogleId("tes.instructor").withName("Instructor 1").withEmail("instructor@email.tmt").withInstitute("TEAMMATES Test Institute 1").withIsInstructor(true).withStudentProfileAttributes(studentAttributes).build();
accountsLogic.createAccount(accountToAdd);
coursesLogic.createCourseAndInstructor("tes.instructor", "tes.course", "TES Course", "UTC");
String line = headerLine + System.lineSeparator() + "t8|n8|e8@g|c1";
enrollResults = studentsLogic.enrollStudentsWithoutDocument(line, "tes.course");
assertEquals(1, enrollResults.studentList.size());
assertEquals(StudentUpdateStatus.NEW, enrollResults.studentList.get(0).updateStatus);
line = headerLine + System.lineSeparator() + "t8|n8a|e8@g|c1";
enrollResults = studentsLogic.enrollStudentsWithoutDocument(line, "tes.course");
assertEquals(1, enrollResults.studentList.size());
assertEquals(StudentUpdateStatus.MODIFIED, enrollResults.studentList.get(0).updateStatus);
line = headerLine + System.lineSeparator() + "t8|n8a|e8@g|c1";
enrollResults = studentsLogic.enrollStudentsWithoutDocument(line, "tes.course");
assertEquals(1, enrollResults.studentList.size());
assertEquals(StudentUpdateStatus.UNMODIFIED, enrollResults.studentList.get(0).updateStatus);
______TS("duplicated emails");
String lineT9 = "t9|n9|e9@g|c9";
String lineT10 = "t10|n10|e9@g|c10";
lines = headerLine + System.lineSeparator() + lineT9 + System.lineSeparator() + lineT10;
try {
studentsLogic.enrollStudentsWithoutDocument(lines, "tes.course");
} catch (EnrollException e) {
assertTrue(e.getMessage().contains(lineT10));
AssertHelper.assertContains("Same email address as the student in line \"" + lineT9 + "\"", e.getMessage());
}
______TS("invalid course id");
String enrollLines = headerLine + System.lineSeparator();
String invalidCourseId = "invalidCourseId";
try {
studentsLogic.enrollStudentsWithoutDocument(enrollLines, invalidCourseId);
signalFailureToDetectException();
} catch (EntityDoesNotExistException e) {
ignoreExpectedException();
}
______TS("empty enroll line");
try {
studentsLogic.enrollStudentsWithoutDocument("", courseIdForEnrollTest);
signalFailureToDetectException();
} catch (EnrollException e) {
ignoreExpectedException();
}
______TS("invalidity info in enroll line");
enrollLines = headerLine + System.lineSeparator() + "invalidline0\ninvalidline1\n";
try {
studentsLogic.enrollStudentsWithoutDocument(enrollLines, courseIdForEnrollTest);
signalFailureToDetectException();
} catch (EnrollException e) {
ignoreExpectedException();
}
}
Aggregations