Search in sources :

Example 1 with DeleteScalingPolicyResult

use of com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyResult in project titus-control-plane by Netflix.

the class AWSAppAutoScalingClientTest method deleteScalingPolicyIsIdempotent.

@Test
public void deleteScalingPolicyIsIdempotent() {
    String jobId = UUID.randomUUID().toString();
    String policyId = UUID.randomUUID().toString();
    AWSApplicationAutoScalingAsync clientAsync = mock(AWSApplicationAutoScalingAsync.class);
    AWSAppScalingConfig config = mock(AWSAppScalingConfig.class);
    AWSAppAutoScalingClient autoScalingClient = new AWSAppAutoScalingClient(clientAsync, config, new NoopRegistry());
    // delete happens successfully on the first attempt
    AtomicBoolean isDeleted = new AtomicBoolean(false);
    when(clientAsync.deleteScalingPolicyAsync(any(), any())).thenAnswer(invocation -> {
        DeleteScalingPolicyRequest request = invocation.getArgument(0);
        AsyncHandler<DeleteScalingPolicyRequest, DeleteScalingPolicyResult> handler = invocation.getArgument(1);
        if (isDeleted.get()) {
            ObjectNotFoundException notFoundException = new ObjectNotFoundException(policyId + " does not exist");
            handler.onError(notFoundException);
            return Future.failed(notFoundException);
        }
        DeleteScalingPolicyResult resultSuccess = new DeleteScalingPolicyResult();
        HttpResponse successResponse = new HttpResponse(null, null);
        successResponse.setStatusCode(200);
        resultSuccess.setSdkHttpMetadata(SdkHttpMetadata.from(successResponse));
        isDeleted.set(true);
        handler.onSuccess(request, resultSuccess);
        return Future.successful(resultSuccess);
    });
    AssertableSubscriber<Void> firstCall = autoScalingClient.deleteScalingPolicy(policyId, jobId).test();
    firstCall.awaitTerminalEvent(2, TimeUnit.SECONDS);
    firstCall.assertNoErrors();
    firstCall.assertCompleted();
    verify(clientAsync, times(1)).deleteScalingPolicyAsync(any(), any());
    // second should complete fast when NotFound and not retry with exponential backoff
    AssertableSubscriber<Void> secondCall = autoScalingClient.deleteScalingPolicy(policyId, jobId).test();
    secondCall.awaitTerminalEvent(2, TimeUnit.SECONDS);
    secondCall.assertNoErrors();
    secondCall.assertCompleted();
    verify(clientAsync, times(2)).deleteScalingPolicyAsync(any(), any());
}
Also used : DeleteScalingPolicyResult(com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyResult) HttpResponse(com.amazonaws.http.HttpResponse) AtomicBoolean(java.util.concurrent.atomic.AtomicBoolean) AWSApplicationAutoScalingAsync(com.amazonaws.services.applicationautoscaling.AWSApplicationAutoScalingAsync) NoopRegistry(com.netflix.spectator.api.NoopRegistry) ObjectNotFoundException(com.amazonaws.services.applicationautoscaling.model.ObjectNotFoundException) DeleteScalingPolicyRequest(com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyRequest) Test(org.junit.Test)

Example 2 with DeleteScalingPolicyResult

use of com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyResult in project titus-control-plane by Netflix.

the class AWSAppAutoScalingClient method deleteScalingPolicy.

@Override
public Completable deleteScalingPolicy(String policyRefId, String jobId) {
    DeleteScalingPolicyRequest deleteScalingPolicyRequest = new DeleteScalingPolicyRequest();
    deleteScalingPolicyRequest.setResourceId(AWSAppAutoScalingUtil.buildGatewayResourceId(jobId, awsAppScalingConfig.getAWSGatewayEndpointPrefix(), awsAppScalingConfig.getRegion(), awsAppScalingConfig.getAWSGatewayEndpointTargetStage()));
    deleteScalingPolicyRequest.setServiceNamespace(SERVICE_NAMESPACE);
    deleteScalingPolicyRequest.setScalableDimension(SCALABLE_DIMENSION);
    deleteScalingPolicyRequest.setPolicyName(buildScalingPolicyName(policyRefId, jobId));
    return RetryWrapper.wrapWithExponentialRetry(String.format("deleteScalingPolicy %s for job %s", policyRefId, jobId), Observable.create(emitter -> awsAppAutoScalingClientAsync.deleteScalingPolicyAsync(deleteScalingPolicyRequest, new AsyncHandler<DeleteScalingPolicyRequest, DeleteScalingPolicyResult>() {

        @Override
        public void onError(Exception exception) {
            if (exception instanceof ObjectNotFoundException) {
                logger.info("Scaling policy does not exist anymore for job/policyRefId {}/{}", jobId, policyRefId);
                emitter.onCompleted();
            } else {
                logger.error("Delete scaling policy exception {} - {}", jobId, exception.getMessage());
                awsAppAutoScalingMetrics.registerAwsDeletePolicyError(exception);
                emitter.onError(AutoScalePolicyException.errorDeletingPolicy(policyRefId, exception.getMessage()));
            }
        }

        @Override
        public void onSuccess(DeleteScalingPolicyRequest request, DeleteScalingPolicyResult deleteScalingPolicyResult) {
            int httpStatusCode = deleteScalingPolicyResult.getSdkHttpMetadata().getHttpStatusCode();
            logger.info("Deleted scaling policy for job/policyRefId {}/{}, status - {}", jobId, policyRefId, httpStatusCode);
            awsAppAutoScalingMetrics.registerAwsDeletePolicySuccess();
            emitter.onCompleted();
        }
    }), Emitter.BackpressureMode.NONE)).toCompletable();
}
Also used : AsyncHandler(com.amazonaws.handlers.AsyncHandler) DeleteScalingPolicyResult(com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyResult) ObjectNotFoundException(com.amazonaws.services.applicationautoscaling.model.ObjectNotFoundException) DeleteScalingPolicyRequest(com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyRequest) AutoScalePolicyException(com.netflix.titus.api.appscale.service.AutoScalePolicyException) ValidationException(com.amazonaws.services.applicationautoscaling.model.ValidationException) ObjectNotFoundException(com.amazonaws.services.applicationautoscaling.model.ObjectNotFoundException)

Aggregations

DeleteScalingPolicyRequest (com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyRequest)2 DeleteScalingPolicyResult (com.amazonaws.services.applicationautoscaling.model.DeleteScalingPolicyResult)2 ObjectNotFoundException (com.amazonaws.services.applicationautoscaling.model.ObjectNotFoundException)2 AsyncHandler (com.amazonaws.handlers.AsyncHandler)1 HttpResponse (com.amazonaws.http.HttpResponse)1 AWSApplicationAutoScalingAsync (com.amazonaws.services.applicationautoscaling.AWSApplicationAutoScalingAsync)1 ValidationException (com.amazonaws.services.applicationautoscaling.model.ValidationException)1 NoopRegistry (com.netflix.spectator.api.NoopRegistry)1 AutoScalePolicyException (com.netflix.titus.api.appscale.service.AutoScalePolicyException)1 AtomicBoolean (java.util.concurrent.atomic.AtomicBoolean)1 Test (org.junit.Test)1