use of com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor in project phpinspectionsea by kalessil.
the class OverridingDeprecatedMethodInspector method buildVisitor.
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new BasePhpElementVisitor() {
public void visitPhpMethod(Method method) {
/* do not process un-reportable classes and interfaces - we are searching real tech. debt here */
final PhpClass clazz = method.getContainingClass();
final PsiElement methodName = NamedElementUtil.getNameIdentifier(method);
if (null == methodName || null == clazz) {
return;
}
final String searchMethodName = method.getName();
/* search for deprecated parent methods */
final PhpClass parent = OpenapiResolveUtil.resolveSuperClass(clazz);
final Method parentMethod = null == parent ? null : OpenapiResolveUtil.resolveMethod(parent, searchMethodName);
if (null != parentMethod) {
if (!method.isDeprecated() && parentMethod.isDeprecated()) {
final String message = patternNeedsDeprecation.replace("%m%", searchMethodName);
holder.registerProblem(methodName, message, ProblemHighlightType.LIKE_DEPRECATED);
return;
}
if (method.isDeprecated() && !parentMethod.isDeprecated()) {
final String message = patternDeprecateParent.replace("%m%", searchMethodName);
holder.registerProblem(methodName, message, ProblemHighlightType.WEAK_WARNING);
return;
}
}
/* search for deprecated interface methods */
if (!method.isDeprecated()) {
for (final PhpClass iface : OpenapiResolveUtil.resolveImplementedInterfaces(clazz)) {
final Method ifaceMethod = OpenapiResolveUtil.resolveMethod(iface, searchMethodName);
if (ifaceMethod != null && ifaceMethod.isDeprecated()) {
final String message = patternNeedsDeprecation.replace("%m%", searchMethodName);
holder.registerProblem(methodName, message, ProblemHighlightType.LIKE_DEPRECATED);
return;
}
}
}
}
};
}
use of com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor in project phpinspectionsea by kalessil.
the class DeclareDirectiveCorrectnessInspector method buildVisitor.
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new BasePhpElementVisitor() {
@Override
public void visitPhpDeclare(@NotNull Declare declare) {
final PsiElement declaration = declare.getFirstPsiChild();
final String declarationText = declaration == null ? null : declaration.getText();
if (declarationText != null && declarationText.indexOf('=') != -1) {
final String directive = declarationText.split("=")[0];
if (!directives.contains(directive.trim())) {
final String message = messagePattern.replace("%d%", directive);
holder.registerProblem(declare, message);
}
}
}
};
}
use of com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor in project phpinspectionsea by kalessil.
the class NonSecureCryptUsageInspector method buildVisitor.
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new BasePhpElementVisitor() {
@Override
public void visitPhpFunctionCall(@NotNull FunctionReference reference) {
final String functionName = reference.getName();
if (functionName == null || !functionName.equals("crypt")) {
return;
}
final PsiElement[] arguments = reference.getParameters();
if ((arguments.length != 1 && arguments.length != 2) || !this.isFromRootNamespace(reference)) {
return;
}
/* Case 1: suggest providing blowfish as the 2nd parameter*/
if (arguments.length == 1) {
holder.registerProblem(reference, messageWeakSalt);
return;
}
/* try resolving 2nd parameter, skip if failed, it contains injections or length is not as expected */
final String saltValue = this.resolveSalt(arguments[1]);
if (null == saltValue || saltValue.length() < 4) {
return;
}
/* Case 2: using $2a$; use $2y$ instead - http://php.net/security/crypt_blowfish.php*/
if (saltValue.startsWith("$2a$")) {
holder.registerProblem(reference, messageInsecureSalt, ProblemHighlightType.GENERIC_ERROR);
return;
}
/* Case 3: -> password_hash(PASSWORD_BCRYPT) in PHP 5.5+ */
final boolean isBlowfish = saltValue.startsWith("$2y$") || saltValue.startsWith("$2x$");
if (isBlowfish) {
PhpLanguageLevel php = PhpProjectConfigurationFacade.getInstance(holder.getProject()).getLanguageLevel();
if (php.compareTo(PhpLanguageLevel.PHP550) >= 0) {
holder.registerProblem(reference, messagePasswordHash, ProblemHighlightType.WEAK_WARNING);
}
}
}
@Nullable
private String resolveSalt(@NotNull PsiElement expression) {
/* collect possible value for further analysis */
final Set<PsiElement> discovered = PossibleValuesDiscoveryUtil.discover(expression);
if (discovered.size() != 1) {
discovered.clear();
return null;
}
/* simplify workflow by handling one expression */
final PsiElement saltExpression = discovered.iterator().next();
final StringBuilder resolvedSaltValue = new StringBuilder();
discovered.clear();
/* resolve string literals and concatenations */
PsiElement current = saltExpression;
while (current instanceof ConcatenationExpression) {
final ConcatenationExpression concat = (ConcatenationExpression) current;
final PsiElement right = ExpressionSemanticUtil.getExpressionTroughParenthesis(concat.getRightOperand());
final StringLiteralExpression part = ExpressionSemanticUtil.resolveAsStringLiteral(right);
resolvedSaltValue.insert(0, part == null ? "<?>" : part.getContents());
current = ExpressionSemanticUtil.getExpressionTroughParenthesis(concat.getLeftOperand());
}
/* don't forget to add the last element */
if (null != current) {
final StringLiteralExpression lastPart = ExpressionSemanticUtil.resolveAsStringLiteral(current);
resolvedSaltValue.insert(0, null == lastPart ? "<?>" : lastPart.getContents());
}
return resolvedSaltValue.toString();
}
};
}
use of com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor in project phpinspectionsea by kalessil.
the class RsaOraclePaddingAttacksInspector method buildVisitor.
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new BasePhpElementVisitor() {
@Override
public void visitPhpFunctionCall(@NotNull FunctionReference reference) {
final List<BooleanSupplier> callbacks = new ArrayList<>(2);
callbacks.add(() -> OpensslRsaOraclePaddingStrategy.apply(holder, reference));
callbacks.add(() -> McryptRsaOraclePaddingStrategy.apply(holder, reference));
for (final BooleanSupplier callback : callbacks) {
if (callback.getAsBoolean()) {
break;
}
}
callbacks.clear();
}
};
}
use of com.kalessil.phpStorm.phpInspectionsEA.openApi.BasePhpElementVisitor in project phpinspectionsea by kalessil.
the class FileFunctionMissUseInspector method buildVisitor.
@Override
@NotNull
public PsiElementVisitor buildVisitor(@NotNull final ProblemsHolder holder, boolean isOnTheFly) {
return new BasePhpElementVisitor() {
@Override
public void visitPhpFunctionCall(@NotNull FunctionReference reference) {
final String functionName = reference.getName();
if (functionName == null || !functionName.equals("file")) {
return;
}
final PsiElement[] arguments = reference.getParameters();
if (arguments.length != 1) {
return;
}
/* function can be silenced, get parent for this case; validate parent structure */
PsiElement parent = reference.getParent();
if (parent instanceof UnaryExpression) {
final PsiElement operation = ((UnaryExpression) parent).getOperation();
if (OpenapiTypesUtil.is(operation, PhpTokenTypes.opSILENCE)) {
parent = parent.getParent();
}
}
if (!(parent instanceof ParameterList) || !OpenapiTypesUtil.isFunctionReference(parent.getParent())) {
return;
}
/* validate parent functions' name (implode or join) and amount of arguments */
final FunctionReference parentReference = (FunctionReference) parent.getParent();
final String parentName = parentReference.getName();
if (parentName == null || (!parentName.equals("implode") && !parentName.equals("join"))) {
return;
}
final PsiElement[] parentParams = parentReference.getParameters();
if (parentParams.length != 2) {
return;
}
/* validate if glue is not empty */
final StringLiteralExpression glue = ExpressionSemanticUtil.resolveAsStringLiteral(parentParams[0]);
if (glue != null && !glue.getContents().isEmpty()) {
return;
}
final String message = String.format(messagePattern, arguments[0].getText());
holder.registerProblem(parentReference, message, ProblemHighlightType.GENERIC_ERROR, new TheLocalFix());
}
};
}
Aggregations