Examples with DescriptorSet com.spotify.protoman.descriptor.DescriptorSet used on opensource projects

Example 36 with DescriptorSet

use of com.spotify.protoman.descriptor.DescriptorSet in project protoman by spotify.

the class SchemaRegistry method buildDescriptorSets.

private BuildDescriptorsResult buildDescriptorSets(final SchemaStorage.Transaction tx, final ImmutableList<SchemaFile> schemaFiles) throws DescriptorBuilderException {
    final long snapshotVersion = tx.getLatestSnapshotVersion();
    // Paths of all updated files
    final ImmutableSet<Path> updatedPaths = schemaFiles.stream().map(SchemaFile::path).collect(toImmutableSet());
    final ImmutableSet<Path> updatedAndDependencies = resolveDependencies(tx, snapshotVersion, updatedPaths);
    try (final DescriptorBuilder descriptorBuilder = descriptorBuilderFactory.newDescriptorBuilder()) {
        // Seed descriptor builder with all files from registry
        // Builder DescriptorSet for what is currently in the registry for the files being updated
        final ImmutableMap<Path, SchemaFile> currentSchemata = updatedAndDependencies.stream().map(path -> tx.schemaFile(snapshotVersion, path)).collect(toImmutableMap(SchemaFile::path, Function.identity()));
        for (SchemaFile file : currentSchemata.values()) {
            descriptorBuilder.setProtoFile(file.path(), file.content());
        }
        // NOTE(staffan): As it is right now, we need compile ALL descriptors to catch breaking
        // changes.
        // NOTE(fredrikd): Not compiling all any more, but keeping this message until
        // tests are added
        // 
        // Consider the case where the following files exists in the repository:
        // 
        // herp/derp.proto:
        // package herp;
        // message Derp {}
        // foo/bar.proto
        // package foo;
        // import "herp/derp.proto"
        // message Bar {
        // Derp derp = 1;
        // }
        // 
        // And a publish request that changes "herp/derp.proto" to:
        // package herp {}
        // message Herpaderp {} // Derp was removed/renamed!
        // 
        // 
        // That change will break "foo/bar.proto" -- BUT protoc will succeeded if we only run it
        // with foo/bar.proto as the input.
        // 
        // So, we either need to either:
        // - Run protoc will ALL files as input, or
        // - Run protoc will ALL files that DEPEND ON a file being changed as input, or
        // - Track dependencies are ensured that types in use are not removed
        final DescriptorBuilder.Result currentResult = descriptorBuilder.buildDescriptor(currentSchemata.keySet().stream());
        @Nullable final DescriptorSet currentDs = createFilteredDescriptorSet(currentResult.fileDescriptorSet(), updatedPaths);
        // Build DescriptorSet for the updated files
        for (SchemaFile schemaFile : schemaFiles) {
            descriptorBuilder.setProtoFile(schemaFile.path(), schemaFile.content());
        }
        final DescriptorBuilder.Result candidateResult = descriptorBuilder.buildDescriptor(Stream.concat(currentSchemata.keySet().stream(), schemaFiles.stream().map(SchemaFile::path)).collect(toImmutableSet()).stream());
        @Nullable final DescriptorSet candidateDs = createFilteredDescriptorSet(candidateResult.fileDescriptorSet(), updatedPaths);
        return BuildDescriptorsResult.create(currentDs, candidateDs, currentResult.compilationError(), candidateResult.compilationError());
    }
}

Example 37 with DescriptorSet

use of com.spotify.protoman.descriptor.DescriptorSet in project protoman by spotify.

the class DescriptorSetUtils method buildDescriptorSetPair.

public static DescriptorSetPair buildDescriptorSetPair(final Path root, final Predicate<Path> filter) throws IOException, URISyntaxException, DescriptorBuilderException {
    final DescriptorSet current = buildDescriptorSet(root.resolve("current"), filter);
    final DescriptorSet candidate = buildDescriptorSet(root.resolve("candidate"), filter);
    return DescriptorSetPair.create(current, candidate);
}

Example 38 with DescriptorSet

use of com.spotify.protoman.descriptor.DescriptorSet in project protoman by spotify.

the class EnumDefaultValueTest method testDisallowedName.

@Parameters(method = "disallowedNames")
@Test
public void testDisallowedName(final String name) throws Exception {
    final DescriptorSet candidate = DescriptorSetUtils.buildDescriptorSet("a.proto", String.format(TEMPLATE, name));
    final ImmutableList<ValidationViolation> violations = schemaValidator.validate(DescriptorSet.empty(), candidate);
    assertThat(violations, contains(validationViolation().description(equalTo("enum value 0 should be used for unknown value, e.g. AN_ENUM_UNSPECIFIED")).type(equalTo(ViolationType.BEST_PRACTICE_VIOLATION)).current(nullValue(GenericDescriptor.class)).candidate(genericDescriptor().sourceCodeInfo(optionalWithValue(sourceCodeInfo().start(filePosition().line(2).column(1)))))));
}

Example 39 with DescriptorSet

use of com.spotify.protoman.descriptor.DescriptorSet in project protoman by spotify.

the class EnumNamingRuleTest method testDisallowedName_existing.

@Parameters(method = "disallowedNames")
@Test
public void testDisallowedName_existing(final String name) throws Exception {
    final DescriptorSet candidate = DescriptorSetUtils.buildDescriptorSet("a.proto", String.format(TEMPLATE, name));
    final ImmutableList<ValidationViolation> violations = schemaValidator.validate(candidate, candidate);
    assertThat(violations, is(empty()));
}

Example 40 with DescriptorSet

use of com.spotify.protoman.descriptor.DescriptorSet in project protoman by spotify.

the class EnumValueNamingRuleTest method testAllowedName_new.

@Parameters(method = "allowedNames")
@Test
public void testAllowedName_new(final String name) throws Exception {
    final DescriptorSet current = DescriptorSet.empty();
    final DescriptorSet candidate = DescriptorSetUtils.buildDescriptorSet("a.proto", "syntax = 'proto3';\n" + "enum EnumWithNewValue {\n" + String.format("  %s = 0;\n", name) + "}");
    final ImmutableList<ValidationViolation> violations = schemaValidator.validate(current, candidate);
    assertThat(violations, is(empty()));
}