Search in sources :

Example 1 with CaseTree

use of com.sun.source.tree.CaseTree in project error-prone by google.

the class ControlFlowVisitor method visitSwitch.

@Override
public Result visitSwitch(SwitchTree node, BreakContext cxt) {
    Result result = null;
    boolean seenDefault = false;
    cxt.loopDepth++;
    try {
        for (CaseTree caseTree : node.getCases()) {
            if (caseTree.getExpression() == null) {
                seenDefault = true;
            }
            if (result == null) {
                result = caseTree.accept(this, cxt);
            } else {
                result = result.or(caseTree.accept(this, cxt));
            }
        }
        if (!seenDefault) {
            result = result.or(NEVER_EXITS);
        }
        return result;
    } finally {
        cxt.loopDepth--;
    }
}
Also used : CaseTree(com.sun.source.tree.CaseTree) Result(com.google.errorprone.refaster.ControlFlowVisitor.Result)

Example 2 with CaseTree

use of com.sun.source.tree.CaseTree in project error-prone by google.

the class WildcardImport method qualifiedNameFix.

/**
 * Add an import for {@code owner}, and qualify all on demand imported references to members of
 * owner by owner's simple name.
 */
private static void qualifiedNameFix(final SuggestedFix.Builder fix, final Symbol owner, VisitorState state) {
    fix.addImport(owner.getQualifiedName().toString());
    final JCCompilationUnit unit = (JCCompilationUnit) state.getPath().getCompilationUnit();
    new TreePathScanner<Void, Void>() {

        @Override
        public Void visitIdentifier(IdentifierTree tree, Void unused) {
            Symbol sym = ASTHelpers.getSymbol(tree);
            if (sym == null) {
                return null;
            }
            Tree parent = getCurrentPath().getParentPath().getLeaf();
            if (parent.getKind() == Tree.Kind.CASE && ((CaseTree) parent).getExpression().equals(tree) && sym.owner.getKind() == ElementKind.ENUM) {
                // switch cases can refer to enum constants by simple name without importing them
                return null;
            }
            if (sym.owner.equals(owner) && unit.starImportScope.includes(sym)) {
                fix.prefixWith(tree, owner.getSimpleName() + ".");
            }
            return null;
        }
    }.scan(unit, null);
}
Also used : JCCompilationUnit(com.sun.tools.javac.tree.JCTree.JCCompilationUnit) CaseTree(com.sun.source.tree.CaseTree) Symbol(com.sun.tools.javac.code.Symbol) IdentifierTree(com.sun.source.tree.IdentifierTree) IdentifierTree(com.sun.source.tree.IdentifierTree) ImportTree(com.sun.source.tree.ImportTree) Tree(com.sun.source.tree.Tree) MemberSelectTree(com.sun.source.tree.MemberSelectTree) CaseTree(com.sun.source.tree.CaseTree) JCTree(com.sun.tools.javac.tree.JCTree) CompilationUnitTree(com.sun.source.tree.CompilationUnitTree)

Example 3 with CaseTree

use of com.sun.source.tree.CaseTree in project error-prone by google.

the class MissingDefault method matchSwitch.

@Override
public Description matchSwitch(SwitchTree tree, VisitorState state) {
    Type switchType = ASTHelpers.getType(tree.getExpression());
    if (switchType.asElement().getKind() == ElementKind.ENUM) {
        // by MissingCasesInEnumSwitch
        return NO_MATCH;
    }
    Optional<? extends CaseTree> maybeDefault = tree.getCases().stream().filter(c -> c.getExpression() == null).findFirst();
    if (!maybeDefault.isPresent()) {
        Description.Builder description = buildDescription(tree);
        if (!tree.getCases().isEmpty()) {
            // Inserting the default after the last case is easier than finding the closing brace
            // for the switch statement. Hopefully we don't often see switches with zero cases.
            CaseTree lastCase = getLast(tree.getCases());
            String replacement;
            if (lastCase.getStatements().isEmpty() || Reachability.canCompleteNormally(Iterables.getLast(lastCase.getStatements()))) {
                replacement = "\nbreak;\ndefault: // fall out\n";
            } else {
                replacement = "\ndefault: // fall out\n";
            }
            description.addFix(SuggestedFix.postfixWith(getLast(tree.getCases()), replacement));
        }
        return description.build();
    }
    CaseTree defaultCase = maybeDefault.get();
    if (!defaultCase.getStatements().isEmpty()) {
        return NO_MATCH;
    }
    // If `default` case is empty, and last in switch, add `// fall out` comment
    // TODO(epmjohnston): Maybe move comment logic to go/bugpattern/FallThrough
    int idx = tree.getCases().indexOf(defaultCase);
    if (idx != tree.getCases().size() - 1) {
        return NO_MATCH;
    }
    int end = state.getEndPosition(tree);
    if (ErrorProneTokens.getTokens(state.getSourceCode().subSequence(state.getEndPosition(defaultCase), end).toString(), state.context).stream().anyMatch(t -> !t.comments().isEmpty())) {
        return NO_MATCH;
    }
    return buildDescription(defaultCase).setMessage("Default case should be documented with a comment").addFix(SuggestedFix.postfixWith(defaultCase, " // fall out")).build();
}
Also used : Iterables(com.google.common.collect.Iterables) ElementKind(javax.lang.model.element.ElementKind) Iterables.getLast(com.google.common.collect.Iterables.getLast) NO_MATCH(com.google.errorprone.matchers.Description.NO_MATCH) CaseTree(com.sun.source.tree.CaseTree) SwitchTreeMatcher(com.google.errorprone.bugpatterns.BugChecker.SwitchTreeMatcher) SwitchTree(com.sun.source.tree.SwitchTree) Reachability(com.google.errorprone.util.Reachability) VisitorState(com.google.errorprone.VisitorState) ErrorProneTokens(com.google.errorprone.util.ErrorProneTokens) Description(com.google.errorprone.matchers.Description) StandardTags(com.google.errorprone.BugPattern.StandardTags) BugPattern(com.google.errorprone.BugPattern) Optional(java.util.Optional) WARNING(com.google.errorprone.BugPattern.SeverityLevel.WARNING) ProvidesFix(com.google.errorprone.BugPattern.ProvidesFix) SuggestedFix(com.google.errorprone.fixes.SuggestedFix) JDK(com.google.errorprone.BugPattern.Category.JDK) ASTHelpers(com.google.errorprone.util.ASTHelpers) Type(com.sun.tools.javac.code.Type) CaseTree(com.sun.source.tree.CaseTree) Type(com.sun.tools.javac.code.Type) Description(com.google.errorprone.matchers.Description)

Example 4 with CaseTree

use of com.sun.source.tree.CaseTree in project error-prone by google.

the class SwitchDefault method matchSwitch.

@Override
public Description matchSwitch(SwitchTree tree, VisitorState state) {
    Optional<? extends CaseTree> maybeDefault = tree.getCases().stream().filter(c -> c.getExpression() == null).findAny();
    if (!maybeDefault.isPresent()) {
        return NO_MATCH;
    }
    // Collect all case trees in the statement group containing the default
    List<CaseTree> defaultStatementGroup = new ArrayList<>();
    Iterator<? extends CaseTree> it = tree.getCases().iterator();
    while (it.hasNext()) {
        CaseTree caseTree = it.next();
        defaultStatementGroup.add(caseTree);
        if (caseTree.getExpression() == null) {
            while (it.hasNext() && caseTree.getStatements().isEmpty()) {
                caseTree = it.next();
                defaultStatementGroup.add(caseTree);
            }
            break;
        }
        if (!caseTree.getStatements().isEmpty()) {
            defaultStatementGroup.clear();
        }
    }
    // Find the position of the default case within the statement group
    int idx = defaultStatementGroup.indexOf(maybeDefault.get());
    SuggestedFix.Builder fix = SuggestedFix.builder();
    CaseTree defaultTree = defaultStatementGroup.get(idx);
    if (it.hasNext()) {
        // Only emit a fix if the default doesn't fall through.
        if (!Reachability.canCompleteNormally(getLast(defaultStatementGroup))) {
            int start = ((JCTree) defaultStatementGroup.get(0)).getStartPosition();
            int end = state.getEndPosition(getLast(defaultStatementGroup));
            String replacement;
            String source = state.getSourceCode().toString();
            // If the default case isn't the last case in its statement group, move it to the end.
            if (idx != defaultStatementGroup.size() - 1) {
                int caseEnd = ((JCTree) getLast(defaultStatementGroup).getStatements().get(0)).getStartPosition();
                int cutStart = ((JCTree) defaultTree).getStartPosition();
                int cutEnd = state.getEndPosition(defaultTree);
                replacement = source.substring(start, cutStart) + source.substring(cutEnd, caseEnd) + "\n" + source.substring(cutStart, cutEnd) + source.substring(caseEnd, end);
            } else {
                replacement = source.substring(start, end);
            }
            fix.replace(start, end, "").postfixWith(getLast(tree.getCases()), replacement);
        }
    } else if (idx != defaultStatementGroup.size() - 1) {
        // If the default case isn't the last case in its statement group, move it to the end.
        fix.delete(defaultTree).prefixWith(getLast(defaultStatementGroup).getStatements().get(0), state.getSourceForNode(defaultTree));
    } else {
        return NO_MATCH;
    }
    Description.Builder description = buildDescription(defaultStatementGroup.get(0));
    if (!fix.isEmpty()) {
        description.addFix(fix.build());
    }
    return description.build();
}
Also used : Iterator(java.util.Iterator) Iterables.getLast(com.google.common.collect.Iterables.getLast) NO_MATCH(com.google.errorprone.matchers.Description.NO_MATCH) CaseTree(com.sun.source.tree.CaseTree) JCTree(com.sun.tools.javac.tree.JCTree) SwitchTreeMatcher(com.google.errorprone.bugpatterns.BugChecker.SwitchTreeMatcher) SwitchTree(com.sun.source.tree.SwitchTree) Reachability(com.google.errorprone.util.Reachability) ArrayList(java.util.ArrayList) VisitorState(com.google.errorprone.VisitorState) List(java.util.List) Description(com.google.errorprone.matchers.Description) BugPattern(com.google.errorprone.BugPattern) Optional(java.util.Optional) SUGGESTION(com.google.errorprone.BugPattern.SeverityLevel.SUGGESTION) ProvidesFix(com.google.errorprone.BugPattern.ProvidesFix) SuggestedFix(com.google.errorprone.fixes.SuggestedFix) Description(com.google.errorprone.matchers.Description) ArrayList(java.util.ArrayList) JCTree(com.sun.tools.javac.tree.JCTree) CaseTree(com.sun.source.tree.CaseTree) SuggestedFix(com.google.errorprone.fixes.SuggestedFix)

Example 5 with CaseTree

use of com.sun.source.tree.CaseTree in project checker-framework by typetools.

the class FenumVisitor method visitSwitch.

@Override
public Void visitSwitch(SwitchTree node, Void p) {
    ExpressionTree expr = node.getExpression();
    AnnotatedTypeMirror exprType = atypeFactory.getAnnotatedType(expr);
    for (CaseTree caseExpr : node.getCases()) {
        List<? extends ExpressionTree> realCaseExprs = TreeUtils.caseTreeGetExpressions(caseExpr);
        // Check all the case options against the switch expression type:
        for (ExpressionTree realCaseExpr : realCaseExprs) {
            AnnotatedTypeMirror caseType = atypeFactory.getAnnotatedType(realCaseExpr);
            // There is currently no "switch" message key, so it is treated
            // identically to "type.incompatible".
            this.commonAssignmentCheck(exprType, caseType, caseExpr, "type.incompatible");
        }
    }
    return super.visitSwitch(node, p);
}
Also used : CaseTree(com.sun.source.tree.CaseTree) ExpressionTree(com.sun.source.tree.ExpressionTree) AnnotatedTypeMirror(org.checkerframework.framework.type.AnnotatedTypeMirror)

Aggregations

CaseTree (com.sun.source.tree.CaseTree)12 SwitchTree (com.sun.source.tree.SwitchTree)5 Tree (com.sun.source.tree.Tree)5 BugPattern (com.google.errorprone.BugPattern)4 VisitorState (com.google.errorprone.VisitorState)4 SwitchTreeMatcher (com.google.errorprone.bugpatterns.BugChecker.SwitchTreeMatcher)4 Description (com.google.errorprone.matchers.Description)4 IdentifierTree (com.sun.source.tree.IdentifierTree)4 Iterables.getLast (com.google.common.collect.Iterables.getLast)3 JDK (com.google.errorprone.BugPattern.Category.JDK)3 ProvidesFix (com.google.errorprone.BugPattern.ProvidesFix)3 WARNING (com.google.errorprone.BugPattern.SeverityLevel.WARNING)3 SuggestedFix (com.google.errorprone.fixes.SuggestedFix)3 NO_MATCH (com.google.errorprone.matchers.Description.NO_MATCH)3 ASTHelpers (com.google.errorprone.util.ASTHelpers)3 ExpressionTree (com.sun.source.tree.ExpressionTree)3 StatementTree (com.sun.source.tree.StatementTree)3 ArrayList (java.util.ArrayList)3 List (java.util.List)3 ElementKind (javax.lang.model.element.ElementKind)3