Examples with ASTArgumentList net.sourceforge.pmd.lang.java.ast.ASTArgumentList used on opensource projects

Example 1 with ASTArgumentList

use of net.sourceforge.pmd.lang.java.ast.ASTArgumentList in project pmd by pmd.

the class InefficientStringBufferingRule method isInStringBufferOperation.

protected static boolean isInStringBufferOperation(Node node, int length, String methodName) {
    if (!(node.getNthParent(length) instanceof ASTStatementExpression)) {
        return false;
    }
    ASTStatementExpression s = node.getFirstParentOfType(ASTStatementExpression.class);
    if (s == null) {
        return false;
    }
    ASTName n = s.getFirstDescendantOfType(ASTName.class);
    if (n == null || n.getImage().indexOf(methodName) == -1 || !(n.getNameDeclaration() instanceof TypedNameDeclaration)) {
        return false;
    }
    // TODO having to hand-code this kind of dredging around is ridiculous
    // we need something to support this in the framework
    // but, "for now" (tm):
    // if more than one arg to append(), skip it
    ASTArgumentList argList = s.getFirstDescendantOfType(ASTArgumentList.class);
    if (argList == null || argList.jjtGetNumChildren() > 1) {
        return false;
    }
    return TypeHelper.isEither((TypedNameDeclaration) n.getNameDeclaration(), StringBuffer.class, StringBuilder.class);
}

Example 2 with ASTArgumentList

use of net.sourceforge.pmd.lang.java.ast.ASTArgumentList in project pmd by pmd.

the class ConstructorCallsOverridableMethodRule method getArgumentTypes.

private static List<String> getArgumentTypes(ASTArguments args) {
    List<String> argumentTypes = new ArrayList<>();
    ASTArgumentList argumentList = args.getFirstChildOfType(ASTArgumentList.class);
    if (argumentList != null) {
        for (int a = 0; a < argumentList.jjtGetNumChildren(); a++) {
            Node expression = argumentList.jjtGetChild(a);
            ASTPrimaryPrefix arg = expression.getFirstDescendantOfType(ASTPrimaryPrefix.class);
            String type = "<unknown>";
            if (arg != null && arg.jjtGetNumChildren() > 0) {
                if (arg.jjtGetChild(0) instanceof ASTLiteral) {
                    ASTLiteral lit = (ASTLiteral) arg.jjtGetChild(0);
                    if (lit.isCharLiteral()) {
                        type = "char";
                    } else if (lit.isFloatLiteral()) {
                        type = "float";
                    } else if (lit.isIntLiteral()) {
                        type = "int";
                    } else if (lit.isStringLiteral()) {
                        type = "String";
                    } else if (lit.jjtGetNumChildren() > 0 && lit.jjtGetChild(0) instanceof ASTBooleanLiteral) {
                        type = "boolean";
                    } else if (lit.isDoubleLiteral()) {
                        type = "double";
                    } else if (lit.isLongLiteral()) {
                        type = "long";
                    }
                } else if (arg.jjtGetChild(0) instanceof ASTName) {
                    // ASTName n = (ASTName)arg.jjtGetChild(0);
                    type = "ref";
                }
            }
            argumentTypes.add(type);
        }
    }
    return argumentTypes;
}

Example 3 with ASTArgumentList

use of net.sourceforge.pmd.lang.java.ast.ASTArgumentList in project pmd by pmd.

the class ConsecutiveLiteralAppendsRule method checkConstructor.

/**
 * Determine if the constructor contains (or ends with) a String Literal
 *
 * @param node
 * @return 1 if the constructor contains string argument, else 0
 */
private int checkConstructor(ASTVariableDeclaratorId node, Object data) {
    Node parent = node.jjtGetParent();
    if (parent.jjtGetNumChildren() >= 2) {
        ASTAllocationExpression allocationExpression = parent.jjtGetChild(1).getFirstDescendantOfType(ASTAllocationExpression.class);
        ASTArgumentList list = null;
        if (allocationExpression != null) {
            list = allocationExpression.getFirstDescendantOfType(ASTArgumentList.class);
        }
        if (list != null) {
            ASTLiteral literal = list.getFirstDescendantOfType(ASTLiteral.class);
            if (!isAdditive(list) && literal != null && literal.isStringLiteral()) {
                return 1;
            }
            return processAdditive(data, 0, list, node);
        }
    }
    return 0;
}

Example 4 with ASTArgumentList

use of net.sourceforge.pmd.lang.java.ast.ASTArgumentList in project pmd by pmd.

the class UselessStringValueOfRule method visit.

@Override
public Object visit(ASTPrimaryPrefix node, Object data) {
    if (node.jjtGetNumChildren() == 0 || !(node.jjtGetChild(0) instanceof ASTName)) {
        return super.visit(node, data);
    }
    String image = ((ASTName) node.jjtGetChild(0)).getImage();
    if ("String.valueOf".equals(image)) {
        Node parent = node.jjtGetParent();
        if (parent.jjtGetNumChildren() != 2) {
            return super.visit(node, data);
        }
        // skip String.valueOf(anyarraytype[])
        ASTArgumentList args = parent.getFirstDescendantOfType(ASTArgumentList.class);
        if (args != null) {
            ASTName arg = args.getFirstDescendantOfType(ASTName.class);
            if (arg != null) {
                NameDeclaration declaration = arg.getNameDeclaration();
                if (declaration != null) {
                    ASTType argType = declaration.getNode().jjtGetParent().jjtGetParent().getFirstDescendantOfType(ASTType.class);
                    if (argType != null && argType.jjtGetChild(0) instanceof ASTReferenceType && ((ASTReferenceType) argType.jjtGetChild(0)).isArray()) {
                        return super.visit(node, data);
                    }
                }
            }
        }
        Node gp = parent.jjtGetParent();
        if (parent instanceof ASTPrimaryExpression && gp instanceof ASTAdditiveExpression && "+".equals(gp.getImage())) {
            boolean ok = false;
            if (gp.jjtGetChild(0) == parent) {
                ok = !isPrimitive(gp.jjtGetChild(1));
            } else {
                for (int i = 0; !ok && gp.jjtGetChild(i) != parent; i++) {
                    ok = !isPrimitive(gp.jjtGetChild(i));
                }
            }
            if (ok) {
                super.addViolation(data, node);
                return data;
            }
        }
    }
    return super.visit(node, data);
}

Example 5 with ASTArgumentList

use of net.sourceforge.pmd.lang.java.ast.ASTArgumentList in project pmd by pmd.

the class ClassScope method determineArgumentTypes.

/**
 * Provide a list of types of the arguments of the given method call. The
 * types are simple type images. If the argument type cannot be determined
 * (e.g. because it is itself the result of a method call), the parameter
 * type is used - so it is assumed, it is of the correct type. This might
 * cause confusion when methods are overloaded.
 *
 * @param occurrence
 *            the method call
 * @param parameterTypes
 *            the parameter types of the called method
 * @return the list of argument types
 */
private List<TypedNameDeclaration> determineArgumentTypes(JavaNameOccurrence occurrence, List<TypedNameDeclaration> parameterTypes) {
    ASTArgumentList arguments = null;
    Node nextSibling;
    if (occurrence.getLocation() instanceof ASTPrimarySuffix) {
        nextSibling = getNextSibling(occurrence.getLocation());
    } else {
        nextSibling = getNextSibling(occurrence.getLocation().jjtGetParent());
    }
    if (nextSibling != null) {
        arguments = nextSibling.getFirstDescendantOfType(ASTArgumentList.class);
    }
    if (arguments == null) {
        return Collections.emptyList();
    }
    List<TypedNameDeclaration> argumentTypes = new ArrayList<>(arguments.jjtGetNumChildren());
    Map<String, Node> qualifiedTypeNames = getEnclosingScope(SourceFileScope.class).getQualifiedTypeNames();
    for (int i = 0; i < arguments.jjtGetNumChildren(); i++) {
        Node argument = arguments.jjtGetChild(i);
        Node child = null;
        boolean isMethodCall = false;
        if (argument.jjtGetNumChildren() > 0 && argument.jjtGetChild(0).jjtGetNumChildren() > 0 && argument.jjtGetChild(0).jjtGetChild(0).jjtGetNumChildren() > 0) {
            child = argument.jjtGetChild(0).jjtGetChild(0).jjtGetChild(0);
            isMethodCall = argument.jjtGetChild(0).jjtGetNumChildren() > 1;
        }
        TypedNameDeclaration type = null;
        if (child instanceof ASTName && !isMethodCall) {
            ASTName name = (ASTName) child;
            Scope s = name.getScope();
            final JavaNameOccurrence nameOccurrence = new JavaNameOccurrence(name, name.getImage());
            while (s != null) {
                if (s.contains(nameOccurrence)) {
                    break;
                }
                s = s.getParent();
            }
            if (s != null) {
                Map<VariableNameDeclaration, List<NameOccurrence>> vars = s.getDeclarations(VariableNameDeclaration.class);
                for (VariableNameDeclaration d : vars.keySet()) {
                    // might be unknown
                    if (d.getImage().equals(name.getImage()) && d.getTypeImage() != null) {
                        String typeName = d.getTypeImage();
                        typeName = qualifyTypeName(typeName);
                        Node declaringNode = qualifiedTypeNames.get(typeName);
                        type = new SimpleTypedNameDeclaration(typeName, this.getEnclosingScope(SourceFileScope.class).resolveType(typeName), determineSuper(declaringNode));
                        break;
                    }
                }
            }
        } else if (child instanceof ASTLiteral) {
            ASTLiteral literal = (ASTLiteral) child;
            if (literal.isCharLiteral()) {
                type = new SimpleTypedNameDeclaration("char", literal.getType());
            } else if (literal.isStringLiteral()) {
                type = new SimpleTypedNameDeclaration("String", literal.getType());
            } else if (literal.isFloatLiteral()) {
                type = new SimpleTypedNameDeclaration("float", literal.getType());
            } else if (literal.isDoubleLiteral()) {
                type = new SimpleTypedNameDeclaration("double", literal.getType());
            } else if (literal.isIntLiteral()) {
                type = new SimpleTypedNameDeclaration("int", literal.getType());
            } else if (literal.isLongLiteral()) {
                type = new SimpleTypedNameDeclaration("long", literal.getType());
            } else if (literal.jjtGetNumChildren() == 1 && literal.jjtGetChild(0) instanceof ASTBooleanLiteral) {
                type = new SimpleTypedNameDeclaration("boolean", Boolean.TYPE);
            }
        } else if (child instanceof ASTAllocationExpression && child.jjtGetChild(0) instanceof ASTClassOrInterfaceType) {
            ASTClassOrInterfaceType classInterface = (ASTClassOrInterfaceType) child.jjtGetChild(0);
            type = convertToSimpleType(classInterface);
        }
        if (type == null && !parameterTypes.isEmpty()) {
            // arguments than parameterTypes
            if (parameterTypes.size() > i) {
                type = parameterTypes.get(i);
            } else {
                // last parameter is the vararg type
                type = parameterTypes.get(parameterTypes.size() - 1);
            }
        }
        if (type != null && type.getType() == null) {
            Class<?> typeBound = resolveGenericType(argument, type.getTypeImage());
            if (typeBound != null) {
                type = new SimpleTypedNameDeclaration(type.getTypeImage(), typeBound);
            }
        }
        argumentTypes.add(type);
    }
    return argumentTypes;
}