use of net.sourceforge.pmd.lang.java.ast.ASTName in project pmd by pmd.
the class UselessStringValueOfRule method visit.
@Override
public Object visit(ASTPrimaryPrefix node, Object data) {
if (node.jjtGetNumChildren() == 0 || !(node.jjtGetChild(0) instanceof ASTName)) {
return super.visit(node, data);
}
String image = ((ASTName) node.jjtGetChild(0)).getImage();
if ("String.valueOf".equals(image)) {
Node parent = node.jjtGetParent();
if (parent.jjtGetNumChildren() != 2) {
return super.visit(node, data);
}
// skip String.valueOf(anyarraytype[])
ASTArgumentList args = parent.getFirstDescendantOfType(ASTArgumentList.class);
if (args != null) {
ASTName arg = args.getFirstDescendantOfType(ASTName.class);
if (arg != null) {
NameDeclaration declaration = arg.getNameDeclaration();
if (declaration != null) {
ASTType argType = declaration.getNode().jjtGetParent().jjtGetParent().getFirstDescendantOfType(ASTType.class);
if (argType != null && argType.jjtGetChild(0) instanceof ASTReferenceType && ((ASTReferenceType) argType.jjtGetChild(0)).isArray()) {
return super.visit(node, data);
}
}
}
}
Node gp = parent.jjtGetParent();
if (parent instanceof ASTPrimaryExpression && gp instanceof ASTAdditiveExpression && "+".equals(gp.getImage())) {
boolean ok = false;
if (gp.jjtGetChild(0) == parent) {
ok = !isPrimitive(gp.jjtGetChild(1));
} else {
for (int i = 0; !ok && gp.jjtGetChild(i) != parent; i++) {
ok = !isPrimitive(gp.jjtGetChild(i));
}
}
if (ok) {
super.addViolation(data, node);
return data;
}
}
}
return super.visit(node, data);
}
use of net.sourceforge.pmd.lang.java.ast.ASTName in project pmd by pmd.
the class ClassScope method determineArgumentTypes.
/**
* Provide a list of types of the arguments of the given method call. The
* types are simple type images. If the argument type cannot be determined
* (e.g. because it is itself the result of a method call), the parameter
* type is used - so it is assumed, it is of the correct type. This might
* cause confusion when methods are overloaded.
*
* @param occurrence
* the method call
* @param parameterTypes
* the parameter types of the called method
* @return the list of argument types
*/
private List<TypedNameDeclaration> determineArgumentTypes(JavaNameOccurrence occurrence, List<TypedNameDeclaration> parameterTypes) {
ASTArgumentList arguments = null;
Node nextSibling;
if (occurrence.getLocation() instanceof ASTPrimarySuffix) {
nextSibling = getNextSibling(occurrence.getLocation());
} else {
nextSibling = getNextSibling(occurrence.getLocation().jjtGetParent());
}
if (nextSibling != null) {
arguments = nextSibling.getFirstDescendantOfType(ASTArgumentList.class);
}
if (arguments == null) {
return Collections.emptyList();
}
List<TypedNameDeclaration> argumentTypes = new ArrayList<>(arguments.jjtGetNumChildren());
Map<String, Node> qualifiedTypeNames = getEnclosingScope(SourceFileScope.class).getQualifiedTypeNames();
for (int i = 0; i < arguments.jjtGetNumChildren(); i++) {
Node argument = arguments.jjtGetChild(i);
Node child = null;
boolean isMethodCall = false;
if (argument.jjtGetNumChildren() > 0 && argument.jjtGetChild(0).jjtGetNumChildren() > 0 && argument.jjtGetChild(0).jjtGetChild(0).jjtGetNumChildren() > 0) {
child = argument.jjtGetChild(0).jjtGetChild(0).jjtGetChild(0);
isMethodCall = argument.jjtGetChild(0).jjtGetNumChildren() > 1;
}
TypedNameDeclaration type = null;
if (child instanceof ASTName && !isMethodCall) {
ASTName name = (ASTName) child;
Scope s = name.getScope();
final JavaNameOccurrence nameOccurrence = new JavaNameOccurrence(name, name.getImage());
while (s != null) {
if (s.contains(nameOccurrence)) {
break;
}
s = s.getParent();
}
if (s != null) {
Map<VariableNameDeclaration, List<NameOccurrence>> vars = s.getDeclarations(VariableNameDeclaration.class);
for (VariableNameDeclaration d : vars.keySet()) {
// might be unknown
if (d.getImage().equals(name.getImage()) && d.getTypeImage() != null) {
String typeName = d.getTypeImage();
typeName = qualifyTypeName(typeName);
Node declaringNode = qualifiedTypeNames.get(typeName);
type = new SimpleTypedNameDeclaration(typeName, this.getEnclosingScope(SourceFileScope.class).resolveType(typeName), determineSuper(declaringNode));
break;
}
}
}
} else if (child instanceof ASTLiteral) {
ASTLiteral literal = (ASTLiteral) child;
if (literal.isCharLiteral()) {
type = new SimpleTypedNameDeclaration("char", literal.getType());
} else if (literal.isStringLiteral()) {
type = new SimpleTypedNameDeclaration("String", literal.getType());
} else if (literal.isFloatLiteral()) {
type = new SimpleTypedNameDeclaration("float", literal.getType());
} else if (literal.isDoubleLiteral()) {
type = new SimpleTypedNameDeclaration("double", literal.getType());
} else if (literal.isIntLiteral()) {
type = new SimpleTypedNameDeclaration("int", literal.getType());
} else if (literal.isLongLiteral()) {
type = new SimpleTypedNameDeclaration("long", literal.getType());
} else if (literal.jjtGetNumChildren() == 1 && literal.jjtGetChild(0) instanceof ASTBooleanLiteral) {
type = new SimpleTypedNameDeclaration("boolean", Boolean.TYPE);
}
} else if (child instanceof ASTAllocationExpression && child.jjtGetChild(0) instanceof ASTClassOrInterfaceType) {
ASTClassOrInterfaceType classInterface = (ASTClassOrInterfaceType) child.jjtGetChild(0);
type = convertToSimpleType(classInterface);
}
if (type == null && !parameterTypes.isEmpty()) {
// arguments than parameterTypes
if (parameterTypes.size() > i) {
type = parameterTypes.get(i);
} else {
// last parameter is the vararg type
type = parameterTypes.get(parameterTypes.size() - 1);
}
}
if (type != null && type.getType() == null) {
Class<?> typeBound = resolveGenericType(argument, type.getTypeImage());
if (typeBound != null) {
type = new SimpleTypedNameDeclaration(type.getTypeImage(), typeBound);
}
}
argumentTypes.add(type);
}
return argumentTypes;
}
use of net.sourceforge.pmd.lang.java.ast.ASTName in project pmd by pmd.
the class MethodScope method addNameOccurrence.
public Set<NameDeclaration> addNameOccurrence(NameOccurrence occurrence) {
JavaNameOccurrence javaOccurrence = (JavaNameOccurrence) occurrence;
Set<NameDeclaration> declarations = findVariableHere(javaOccurrence);
if (!declarations.isEmpty() && !javaOccurrence.isThisOrSuper()) {
for (NameDeclaration decl : declarations) {
getVariableDeclarations().get(decl).add(javaOccurrence);
Node n = javaOccurrence.getLocation();
if (n instanceof ASTName) {
((ASTName) n).setNameDeclaration(decl);
}
// TODO what to do with PrimarySuffix case?
}
}
return declarations;
}
use of net.sourceforge.pmd.lang.java.ast.ASTName in project pmd by pmd.
the class NameFinder method checkForNameChild.
private void checkForNameChild(JavaNode node) {
if (node.getImage() != null) {
add(new JavaNameOccurrence(node, node.getImage()));
}
if (node.jjtGetNumChildren() > 0 && node.jjtGetChild(0) instanceof ASTName) {
ASTName grandchild = (ASTName) node.jjtGetChild(0);
for (StringTokenizer st = new StringTokenizer(grandchild.getImage(), "."); st.hasMoreTokens(); ) {
add(new JavaNameOccurrence(grandchild, st.nextToken()));
}
}
if (node.jjtGetNumChildren() > 1 && node.jjtGetChild(1) instanceof ASTMethodReference) {
ASTMethodReference methodRef = (ASTMethodReference) node.jjtGetChild(1);
add(new JavaNameOccurrence(methodRef, methodRef.getImage()));
}
if (node instanceof ASTPrimarySuffix) {
ASTPrimarySuffix suffix = (ASTPrimarySuffix) node;
if (suffix.isArguments()) {
JavaNameOccurrence occurrence = names.get(names.size() - 1);
occurrence.setIsMethodOrConstructorInvocation();
ASTArguments args = (ASTArguments) ((ASTPrimarySuffix) node).jjtGetChild(0);
occurrence.setArgumentCount(args.getArgumentCount());
} else if (suffix.jjtGetNumChildren() == 1 && suffix.jjtGetChild(0) instanceof ASTMemberSelector) {
ASTMemberSelector member = (ASTMemberSelector) suffix.jjtGetChild(0);
if (member.jjtGetNumChildren() == 1 && member.jjtGetChild(0) instanceof ASTMethodReference) {
ASTMethodReference methodRef = (ASTMethodReference) member.jjtGetChild(0);
add(new JavaNameOccurrence(methodRef, methodRef.getImage()));
} else {
add(new JavaNameOccurrence(member, member.getImage()));
}
}
}
}
use of net.sourceforge.pmd.lang.java.ast.ASTName in project pmd by pmd.
the class ForLoopCanBeForeachRule method occurenceIsListGet.
/**
* @return true if this occurence is as an argument to List.get on the correct list
*/
private boolean occurenceIsListGet(NameOccurrence occ, String listName) {
if (occ.getLocation() instanceof ASTName) {
ASTPrimarySuffix suffix = occ.getLocation().getFirstParentOfType(ASTPrimarySuffix.class);
if (suffix == null) {
return false;
}
Node prefix = suffix.jjtGetParent().jjtGetChild(0);
if (!(prefix instanceof ASTPrimaryPrefix) && prefix.jjtGetNumChildren() != 1 && !(prefix.jjtGetChild(0) instanceof ASTName)) {
return false;
}
String callImage = prefix.jjtGetChild(0).getImage();
return (listName + ".get").equals(callImage);
}
return false;
}
Aggregations