use of net.sourceforge.pmd.lang.java.ast.ASTPrimaryPrefix in project pmd by pmd.
the class DoubleCheckedLockingRule method visit.
@Override
public Object visit(ASTMethodDeclaration node, Object data) {
if (node.getResultType().isVoid()) {
return super.visit(node, data);
}
ASTType typeNode = (ASTType) node.getResultType().jjtGetChild(0);
if (typeNode.jjtGetNumChildren() == 0 || !(typeNode.jjtGetChild(0) instanceof ASTReferenceType)) {
return super.visit(node, data);
}
List<ASTReturnStatement> rsl = node.findDescendantsOfType(ASTReturnStatement.class);
if (rsl.size() != 1) {
return super.visit(node, data);
}
ASTReturnStatement rs = rsl.get(0);
List<ASTPrimaryExpression> pel = rs.findDescendantsOfType(ASTPrimaryExpression.class);
ASTPrimaryExpression ape = pel.get(0);
Node lastChild = ape.jjtGetChild(ape.jjtGetNumChildren() - 1);
String returnVariableName = null;
if (lastChild instanceof ASTPrimaryPrefix) {
returnVariableName = getNameFromPrimaryPrefix((ASTPrimaryPrefix) lastChild);
}
// With Java5 and volatile keyword, DCL is no longer an issue
if (returnVariableName == null || this.volatileFields.contains(returnVariableName)) {
return super.visit(node, data);
}
// field, then it's ok, too
if (checkLocalVariableUsage(node, returnVariableName)) {
return super.visit(node, data);
}
List<ASTIfStatement> isl = node.findDescendantsOfType(ASTIfStatement.class);
if (isl.size() == 2) {
ASTIfStatement is = isl.get(0);
if (ifVerify(is, returnVariableName)) {
// find synchronized
List<ASTSynchronizedStatement> ssl = is.findDescendantsOfType(ASTSynchronizedStatement.class);
if (ssl.size() == 1) {
ASTSynchronizedStatement ss = ssl.get(0);
isl = ss.findDescendantsOfType(ASTIfStatement.class);
if (isl.size() == 1) {
ASTIfStatement is2 = isl.get(0);
if (ifVerify(is2, returnVariableName)) {
List<ASTStatementExpression> sel = is2.findDescendantsOfType(ASTStatementExpression.class);
if (sel.size() == 1) {
ASTStatementExpression se = sel.get(0);
if (se.jjtGetNumChildren() == 3) {
// primaryExpression, AssignmentOperator, Expression
if (se.jjtGetChild(0) instanceof ASTPrimaryExpression) {
ASTPrimaryExpression pe = (ASTPrimaryExpression) se.jjtGetChild(0);
if (matchName(pe, returnVariableName)) {
if (se.jjtGetChild(1) instanceof ASTAssignmentOperator) {
addViolation(data, node);
}
}
}
}
}
}
}
}
}
}
return super.visit(node, data);
}
use of net.sourceforge.pmd.lang.java.ast.ASTPrimaryPrefix in project pmd by pmd.
the class DoubleCheckedLockingRule method matchName.
private boolean matchName(ASTPrimaryExpression ape, String name) {
if (ape.jjtGetNumChildren() == 1 && ape.jjtGetChild(0) instanceof ASTPrimaryPrefix) {
ASTPrimaryPrefix pp = (ASTPrimaryPrefix) ape.jjtGetChild(0);
String name2 = getNameFromPrimaryPrefix(pp);
if (name2 != null && name2.equals(name)) {
return true;
}
}
return false;
}
use of net.sourceforge.pmd.lang.java.ast.ASTPrimaryPrefix in project pmd by pmd.
the class DoubleCheckedLockingRule method checkLocalVariableUsage.
private boolean checkLocalVariableUsage(ASTMethodDeclaration node, String returnVariableName) {
List<ASTLocalVariableDeclaration> locals = node.findDescendantsOfType(ASTLocalVariableDeclaration.class);
ASTVariableInitializer initializer = null;
for (ASTLocalVariableDeclaration l : locals) {
ASTVariableDeclaratorId id = l.getFirstDescendantOfType(ASTVariableDeclaratorId.class);
if (id != null && id.hasImageEqualTo(returnVariableName)) {
initializer = l.getFirstDescendantOfType(ASTVariableInitializer.class);
break;
}
}
// the return variable name doesn't seem to be a local variable
if (initializer == null) {
return false;
}
// verify the value with which the local variable is initialized
if (initializer.jjtGetNumChildren() > 0 && initializer.jjtGetChild(0) instanceof ASTExpression && initializer.jjtGetChild(0).jjtGetNumChildren() > 0 && initializer.jjtGetChild(0).jjtGetChild(0) instanceof ASTPrimaryExpression && initializer.jjtGetChild(0).jjtGetChild(0).jjtGetNumChildren() > 0 && initializer.jjtGetChild(0).jjtGetChild(0).jjtGetChild(0) instanceof ASTPrimaryPrefix && initializer.jjtGetChild(0).jjtGetChild(0).jjtGetChild(0).jjtGetNumChildren() > 0 && initializer.jjtGetChild(0).jjtGetChild(0).jjtGetChild(0).jjtGetChild(0) instanceof ASTName) {
ASTName name = (ASTName) initializer.jjtGetChild(0).jjtGetChild(0).jjtGetChild(0).jjtGetChild(0);
if (name == null || !volatileFields.contains(name.getImage())) {
return false;
}
} else {
// not a simple assignment
return false;
}
// now check every usage/assignment of the variable
List<ASTName> names = node.findDescendantsOfType(ASTName.class);
for (ASTName n : names) {
if (!n.hasImageEqualTo(returnVariableName)) {
continue;
}
Node expression = n.getNthParent(3);
if (expression instanceof ASTEqualityExpression) {
continue;
}
if (expression instanceof ASTStatementExpression) {
if (expression.jjtGetNumChildren() > 2 && expression.jjtGetChild(1) instanceof ASTAssignmentOperator) {
ASTName value = expression.jjtGetChild(2).getFirstDescendantOfType(ASTName.class);
if (value == null || !volatileFields.contains(value.getImage())) {
return false;
}
}
}
}
return true;
}
use of net.sourceforge.pmd.lang.java.ast.ASTPrimaryPrefix in project pmd by pmd.
the class SingletonClassReturningNewInstanceRule method getReturnVariableName.
private String getReturnVariableName(ASTMethodDeclaration node) {
List<ASTReturnStatement> rsl = node.findDescendantsOfType(ASTReturnStatement.class);
ASTReturnStatement rs = rsl.get(0);
List<ASTPrimaryExpression> pel = rs.findDescendantsOfType(ASTPrimaryExpression.class);
ASTPrimaryExpression ape = pel.get(0);
Node lastChild = ape.jjtGetChild(0);
String returnVariableName = null;
if (lastChild instanceof ASTPrimaryPrefix) {
returnVariableName = getNameFromPrimaryPrefix((ASTPrimaryPrefix) lastChild);
}
/*
* if(lastChild instanceof ASTPrimarySuffix){ returnVariableName =
* getNameFromPrimarySuffix((ASTPrimarySuffix) lastChild); }
*/
return returnVariableName;
}
use of net.sourceforge.pmd.lang.java.ast.ASTPrimaryPrefix in project pmd by pmd.
the class ForLoopCanBeForeachRule method occurenceIsListGet.
/**
* @return true if this occurence is as an argument to List.get on the correct list
*/
private boolean occurenceIsListGet(NameOccurrence occ, String listName) {
if (occ.getLocation() instanceof ASTName) {
ASTPrimarySuffix suffix = occ.getLocation().getFirstParentOfType(ASTPrimarySuffix.class);
if (suffix == null) {
return false;
}
Node prefix = suffix.jjtGetParent().jjtGetChild(0);
if (!(prefix instanceof ASTPrimaryPrefix) && prefix.jjtGetNumChildren() != 1 && !(prefix.jjtGetChild(0) instanceof ASTName)) {
return false;
}
String callImage = prefix.jjtGetChild(0).getImage();
return (listName + ".get").equals(callImage);
}
return false;
}
Aggregations