use of nl.ramsolutions.sw.magik.analysis.typing.types.Parameter in project magik-tools by StevenLooman.
the class MethodArgumentCountTypedCheck method walkPostMethodInvocation.
@Override
protected void walkPostMethodInvocation(final AstNode node) {
// Ensure there are arguments to check.
final AstNode argumentsNode = node.getFirstChild(MagikGrammar.ARGUMENTS);
if (argumentsNode == null) {
return;
}
// Don't bother checking scatter.
final boolean anyScatter = argumentsNode.getChildren(MagikGrammar.ARGUMENT).stream().anyMatch(argumentNode -> {
AstNode unaryExprNode = AstQuery.getFirstChildFromChain(node, MagikGrammar.EXPRESSION, MagikGrammar.UNARY_EXPRESSION);
String tokenValue = unaryExprNode != null ? unaryExprNode.getTokenValue() : null;
return tokenValue != null && tokenValue.equalsIgnoreCase(MagikKeyword.SCATTER.getValue());
});
if (anyScatter) {
return;
}
// Get type.
final AbstractType calledType = this.getTypeInvokedOn(node);
if (calledType == UndefinedType.INSTANCE) {
// Cannot give any useful information, so abort.
return;
}
// Get methods.
final MethodInvocationNodeHelper helper = new MethodInvocationNodeHelper(node);
final String methodName = helper.getMethodName();
for (final Method method : calledType.getMethods(methodName)) {
final List<Parameter> parameters = method.getParameters();
if (parameters.isEmpty()) {
continue;
}
// Match arguments against method.parameters.
final List<AstNode> argumentNodes = argumentsNode.getChildren(MagikGrammar.ARGUMENT);
final List<Parameter> checkedParameters = method.getParameters().stream().filter(parameter -> parameter.is(Parameter.Modifier.NONE)).collect(Collectors.toList());
if (checkedParameters.size() > argumentNodes.size()) {
final String message = String.format(MESSAGE, methodName);
this.addIssue(node, message);
}
}
}
use of nl.ramsolutions.sw.magik.analysis.typing.types.Parameter in project magik-tools by StevenLooman.
the class MethodArgumentParameterTypedCheck method walkPostMethodInvocation.
@Override
protected void walkPostMethodInvocation(final AstNode node) {
// Ensure there are arguments to check.
final AstNode argumentsNode = node.getFirstChild(MagikGrammar.ARGUMENTS);
if (argumentsNode == null) {
return;
}
// Get type.
final AbstractType calledType = this.getTypeInvokedOn(node);
if (calledType == UndefinedType.INSTANCE) {
// Cannot give any useful information, so abort.
return;
}
// Get types for arguments.
final LocalTypeReasoner reasoner = this.getReasoner();
final List<AstNode> argumentNodes = argumentsNode.getChildren(MagikGrammar.ARGUMENT).stream().collect(Collectors.toList());
final List<ExpressionResult> argumentTypes = argumentNodes.stream().map(argumentNode -> argumentNode.getFirstChild(MagikGrammar.EXPRESSION)).map(reasoner::getNodeType).collect(Collectors.toList());
// Get methods.
final MethodInvocationNodeHelper helper = new MethodInvocationNodeHelper(node);
final String methodName = helper.getMethodName();
for (final Method method : calledType.getMethods(methodName)) {
final List<Parameter> parameters = method.getParameters();
if (parameters.isEmpty()) {
continue;
}
final List<AbstractType> parameterTypes = method.getParameters().stream().filter(parameter -> parameter.is(Parameter.Modifier.NONE) || // Don't check gather.
parameter.is(Parameter.Modifier.OPTIONAL)).map(Parameter::getType).collect(Collectors.toList());
// Test parameter type against argument type.
final int size = Math.min(parameterTypes.size(), argumentTypes.size());
IntStream.range(0, size).forEach(index -> {
final AbstractType parameterType = parameterTypes.get(index);
if (parameterType == UndefinedType.INSTANCE) {
return;
}
final AbstractType argumentType = argumentTypes.get(index).get(0, UndefinedType.INSTANCE);
if (!TypeMatcher.typeMatches(argumentType, parameterType)) {
final AstNode argumentNode = argumentNodes.get(index);
final String message = String.format(MESSAGE, argumentType.getFullName(), parameterType.getFullName());
this.addIssue(argumentNode, message);
}
});
}
}
use of nl.ramsolutions.sw.magik.analysis.typing.types.Parameter in project magik-tools by StevenLooman.
the class MethodArgumentParameterTypeCheckTest method testArgumentTypeMatches.
@Test
void testArgumentTypeMatches() {
final String code = "integer.m1(:symbol)";
final ITypeKeeper typeKeeper = new TypeKeeper();
final MagikType integerType = (MagikType) typeKeeper.getType(GlobalReference.of("sw:integer"));
final AbstractType symbolType = typeKeeper.getType(GlobalReference.of("sw:symbol"));
final Parameter param1 = new Parameter("p1", Parameter.Modifier.NONE, symbolType);
integerType.addMethod(EnumSet.noneOf(Method.Modifier.class), null, "m1()", List.of(param1), null, ExpressionResult.UNDEFINED);
final MagikTypedCheck check = new MethodArgumentParameterTypedCheck();
final List<MagikIssue> checkResults = this.runCheck(code, typeKeeper, check);
assertThat(checkResults).isEmpty();
}
use of nl.ramsolutions.sw.magik.analysis.typing.types.Parameter in project magik-tools by StevenLooman.
the class MethodArgumentParameterTypeCheckTest method testArgumentTypeNotMatches.
@Test
void testArgumentTypeNotMatches() {
final String code = "integer.m1(1)";
final ITypeKeeper typeKeeper = new TypeKeeper();
final MagikType integerType = (MagikType) typeKeeper.getType(GlobalReference.of("sw:integer"));
final AbstractType symbolType = typeKeeper.getType(GlobalReference.of("sw:symbol"));
final Parameter param1 = new Parameter("p1", Parameter.Modifier.NONE, symbolType);
integerType.addMethod(EnumSet.noneOf(Method.Modifier.class), null, "m1()", List.of(param1), null, ExpressionResult.UNDEFINED);
final MagikTypedCheck check = new MethodArgumentParameterTypedCheck();
final List<MagikIssue> checkResults = this.runCheck(code, typeKeeper, check);
assertThat(checkResults).hasSize(1);
}
use of nl.ramsolutions.sw.magik.analysis.typing.types.Parameter in project magik-tools by StevenLooman.
the class MethodArgumentParameterTypeCheckTest method testTooManyArguments.
@Test
void testTooManyArguments() {
final String code = "integer.m1(:symbol, :symbol)";
final ITypeKeeper typeKeeper = new TypeKeeper();
final MagikType integerType = (MagikType) typeKeeper.getType(GlobalReference.of("sw:integer"));
final AbstractType symbolType = typeKeeper.getType(GlobalReference.of("sw:symbol"));
final Parameter param1 = new Parameter("p1", Parameter.Modifier.NONE, symbolType);
integerType.addMethod(EnumSet.noneOf(Method.Modifier.class), null, "m1()", List.of(param1), null, ExpressionResult.UNDEFINED);
final MagikTypedCheck check = new MethodArgumentParameterTypedCheck();
final List<MagikIssue> checkResults = this.runCheck(code, typeKeeper, check);
assertThat(checkResults).isEmpty();
}
Aggregations