Search in sources :

Example 1 with LogicalPortInfoEntry

use of org.openkilda.messaging.info.switches.LogicalPortInfoEntry in project open-kilda by telstra.

the class ValidationServiceImplTest method calculateMisconfiguredLogicalPortDifferentPortOrderTest.

@Test
public void calculateMisconfiguredLogicalPortDifferentPortOrderTest() {
    ValidationServiceImpl validationService = new ValidationServiceImpl(persistenceManager().build());
    LogicalPortInfoEntry actual = LogicalPortInfoEntry.builder().type(org.openkilda.messaging.info.switches.LogicalPortType.LAG).logicalPortNumber(LOGICAL_PORT_NUMBER_1).physicalPorts(Lists.newArrayList(PHYSICAL_PORT_1, PHYSICAL_PORT_2, PHYSICAL_PORT_3)).build();
    LogicalPortInfoEntry expected = LogicalPortInfoEntry.builder().type(org.openkilda.messaging.info.switches.LogicalPortType.LAG).logicalPortNumber(LOGICAL_PORT_NUMBER_1).physicalPorts(Lists.newArrayList(PHYSICAL_PORT_3, PHYSICAL_PORT_2, PHYSICAL_PORT_1)).build();
    LogicalPortInfoEntry difference = validationService.calculateMisconfiguredLogicalPort(expected, actual);
    // physical ports are equal. Only order is different. So port difference must be null
    assertNull(difference.getActual().getPhysicalPorts());
    assertNull(difference.getExpected().getPhysicalPorts());
}
Also used : LogicalPortInfoEntry(org.openkilda.messaging.info.switches.LogicalPortInfoEntry) Test(org.junit.Test)

Example 2 with LogicalPortInfoEntry

use of org.openkilda.messaging.info.switches.LogicalPortInfoEntry in project open-kilda by telstra.

the class ValidationServiceImplTest method validateLogicalPorts.

@Test
public void validateLogicalPorts() {
    ValidationService validationService = new ValidationServiceImpl(persistenceManager().build());
    LogicalPort proper = buildLogicalPort(LOGICAL_PORT_NUMBER_1, PHYSICAL_PORT_2, PHYSICAL_PORT_1);
    LogicalPort misconfigured = buildLogicalPort(LOGICAL_PORT_NUMBER_2, LogicalPortType.BFD, PHYSICAL_PORT_3);
    LogicalPort excess = buildLogicalPort(LOGICAL_PORT_NUMBER_4, PHYSICAL_PORT_6);
    LogicalPort bfdExcess = buildLogicalPort(LOGICAL_PORT_NUMBER_5, LogicalPortType.BFD, PHYSICAL_PORT_7);
    ValidateLogicalPortsResult result = validationService.validateLogicalPorts(SWITCH_ID_A, Lists.newArrayList(proper, misconfigured, excess, bfdExcess));
    assertEquals(1, result.getProperLogicalPorts().size());
    // bfdExcess port shouldn't be in this list
    assertEquals(1, result.getExcessLogicalPorts().size());
    assertEquals(1, result.getMissingLogicalPorts().size());
    assertEquals(1, result.getMisconfiguredLogicalPorts().size());
    assertEqualLogicalPort(proper, result.getProperLogicalPorts().get(0));
    assertEqualLogicalPort(excess, result.getExcessLogicalPorts().get(0));
    LogicalPortInfoEntry missing = LogicalPortInfoEntry.builder().type(org.openkilda.messaging.info.switches.LogicalPortType.LAG).logicalPortNumber(LOGICAL_PORT_NUMBER_3).physicalPorts(Lists.newArrayList(PHYSICAL_PORT_5, PHYSICAL_PORT_6)).build();
    assertEquals(missing, result.getMissingLogicalPorts().get(0));
    LogicalPortInfoEntry misconfiguredEntry = LogicalPortInfoEntry.builder().type(org.openkilda.messaging.info.switches.LogicalPortType.BFD).logicalPortNumber(LOGICAL_PORT_NUMBER_2).physicalPorts(Lists.newArrayList(PHYSICAL_PORT_3)).actual(new LogicalPortMisconfiguredInfoEntry(org.openkilda.messaging.info.switches.LogicalPortType.BFD, Lists.newArrayList(PHYSICAL_PORT_3))).expected(new LogicalPortMisconfiguredInfoEntry(org.openkilda.messaging.info.switches.LogicalPortType.LAG, Lists.newArrayList(PHYSICAL_PORT_3, PHYSICAL_PORT_4))).build();
    assertEquals(misconfiguredEntry, result.getMisconfiguredLogicalPorts().get(0));
}
Also used : LogicalPort(org.openkilda.messaging.model.grpc.LogicalPort) LagLogicalPort(org.openkilda.model.LagLogicalPort) LogicalPortInfoEntry(org.openkilda.messaging.info.switches.LogicalPortInfoEntry) LogicalPortMisconfiguredInfoEntry(org.openkilda.messaging.info.switches.LogicalPortMisconfiguredInfoEntry) ValidationService(org.openkilda.wfm.topology.switchmanager.service.ValidationService) ValidateLogicalPortsResult(org.openkilda.wfm.topology.switchmanager.model.ValidateLogicalPortsResult) Test(org.junit.Test)

Example 3 with LogicalPortInfoEntry

use of org.openkilda.messaging.info.switches.LogicalPortInfoEntry in project open-kilda by telstra.

the class ValidationServiceImpl method validateLogicalPorts.

@Override
public ValidateLogicalPortsResult validateLogicalPorts(SwitchId switchId, List<LogicalPort> presentLogicalPorts) {
    Map<Integer, LogicalPortInfoEntry> expectedPorts = lagLogicalPortRepository.findBySwitchId(switchId).stream().map(LogicalPortMapper.INSTANCE::map).peek(port -> Collections.sort(port.getPhysicalPorts())).collect(Collectors.toMap(LogicalPortInfoEntry::getLogicalPortNumber, Function.identity()));
    Map<Integer, LogicalPortInfoEntry> actualPorts = presentLogicalPorts.stream().map(LogicalPortMapper.INSTANCE::map).peek(port -> Collections.sort(port.getPhysicalPorts())).collect(Collectors.toMap(LogicalPortInfoEntry::getLogicalPortNumber, Function.identity()));
    List<LogicalPortInfoEntry> properPorts = new ArrayList<>();
    List<LogicalPortInfoEntry> missingPorts = new ArrayList<>();
    List<LogicalPortInfoEntry> excessPorts = new ArrayList<>();
    List<LogicalPortInfoEntry> misconfiguredPorts = new ArrayList<>();
    for (Entry<Integer, LogicalPortInfoEntry> entry : expectedPorts.entrySet()) {
        int portNumber = entry.getKey();
        LogicalPortInfoEntry expected = entry.getValue();
        if (actualPorts.containsKey(portNumber)) {
            LogicalPortInfoEntry actual = actualPorts.get(portNumber);
            if (actual.equals(expected)) {
                properPorts.add(actual);
            } else {
                misconfiguredPorts.add(calculateMisconfiguredLogicalPort(expected, actual));
            }
        } else {
            missingPorts.add(expected);
        }
    }
    for (Entry<Integer, LogicalPortInfoEntry> entry : actualPorts.entrySet()) {
        if (LogicalPortType.BFD.equals(entry.getValue().getType())) {
            // At this moment we do not validate BFD ports, so Kilda wouldn't include BFD ports into excess list
            continue;
        }
        if (!expectedPorts.containsKey(entry.getKey())) {
            excessPorts.add(entry.getValue());
        }
    }
    return new ValidateLogicalPortsResult(ImmutableList.copyOf(properPorts), ImmutableList.copyOf(missingPorts), ImmutableList.copyOf(excessPorts), ImmutableList.copyOf(misconfiguredPorts));
}
Also used : Arrays(java.util.Arrays) FlowPath(org.openkilda.model.FlowPath) ValidationService(org.openkilda.wfm.topology.switchmanager.service.ValidationService) LogicalPortInfoEntry(org.openkilda.messaging.info.switches.LogicalPortInfoEntry) Map(java.util.Map) FlowMeterRepository(org.openkilda.persistence.repositories.FlowMeterRepository) ValidateLogicalPortsResult(org.openkilda.wfm.topology.switchmanager.model.ValidateLogicalPortsResult) ImmutableSet(com.google.common.collect.ImmutableSet) LogicalPortMisconfiguredInfoEntry(org.openkilda.messaging.info.switches.LogicalPortMisconfiguredInfoEntry) FlowPathRepository(org.openkilda.persistence.repositories.FlowPathRepository) MeterEntryConverter(org.openkilda.wfm.topology.switchmanager.mappers.MeterEntryConverter) Collection(java.util.Collection) Set(java.util.Set) GroupEntryConverter(org.openkilda.wfm.topology.switchmanager.mappers.GroupEntryConverter) Collectors(java.util.stream.Collectors) String.format(java.lang.String.format) Sets(com.google.common.collect.Sets) Objects(java.util.Objects) MeterInfoEntry(org.openkilda.messaging.info.switches.MeterInfoEntry) Slf4j(lombok.extern.slf4j.Slf4j) List(java.util.List) Entry(java.util.Map.Entry) Optional(java.util.Optional) Meter(org.openkilda.model.Meter) GroupInfoEntry(org.openkilda.messaging.info.switches.GroupInfoEntry) MeterMisconfiguredInfoEntry(org.openkilda.messaging.info.switches.MeterMisconfiguredInfoEntry) SwitchRepository(org.openkilda.persistence.repositories.SwitchRepository) FlowMeter(org.openkilda.model.FlowMeter) LogicalPort(org.openkilda.messaging.model.grpc.LogicalPort) BucketEntry(org.openkilda.messaging.info.switches.GroupInfoEntry.BucketEntry) Function(java.util.function.Function) CollectionUtils(org.apache.commons.collections4.CollectionUtils) ArrayList(java.util.ArrayList) HashSet(java.util.HashSet) SwitchNotFoundException(org.openkilda.wfm.topology.switchmanager.error.SwitchNotFoundException) ValidateRulesResult(org.openkilda.wfm.topology.switchmanager.model.ValidateRulesResult) ImmutableList(com.google.common.collect.ImmutableList) Cookie(org.openkilda.model.cookie.Cookie) LogicalPortMapper(org.openkilda.wfm.topology.switchmanager.mappers.LogicalPortMapper) PersistenceManager(org.openkilda.persistence.PersistenceManager) ValidateGroupsResult(org.openkilda.wfm.topology.switchmanager.model.ValidateGroupsResult) LogicalPortType(org.openkilda.messaging.info.switches.LogicalPortType) Switch(org.openkilda.model.Switch) MeterSpeakerData(org.openkilda.rulemanager.MeterSpeakerData) FlowSpeakerData(org.openkilda.rulemanager.FlowSpeakerData) Collectors.toList(java.util.stream.Collectors.toList) ValidateMetersResult(org.openkilda.wfm.topology.switchmanager.model.ValidateMetersResult) SwitchId(org.openkilda.model.SwitchId) GroupSpeakerData(org.openkilda.rulemanager.GroupSpeakerData) LagLogicalPortRepository(org.openkilda.persistence.repositories.LagLogicalPortRepository) VisibleForTesting(com.google.common.annotations.VisibleForTesting) Comparator(java.util.Comparator) Collections(java.util.Collections) LogicalPortInfoEntry(org.openkilda.messaging.info.switches.LogicalPortInfoEntry) ArrayList(java.util.ArrayList) ValidateLogicalPortsResult(org.openkilda.wfm.topology.switchmanager.model.ValidateLogicalPortsResult)

Example 4 with LogicalPortInfoEntry

use of org.openkilda.messaging.info.switches.LogicalPortInfoEntry in project open-kilda by telstra.

the class ValidationServiceImplTest method assertEqualLogicalPort.

private void assertEqualLogicalPort(LogicalPort expected, LogicalPortInfoEntry actual) {
    LogicalPortInfoEntry expectedPortInfo = LogicalPortMapper.INSTANCE.map(expected);
    Collections.sort(expectedPortInfo.getPhysicalPorts());
    Collections.sort(actual.getPhysicalPorts());
    assertEquals(expectedPortInfo, actual);
}
Also used : LogicalPortInfoEntry(org.openkilda.messaging.info.switches.LogicalPortInfoEntry)

Example 5 with LogicalPortInfoEntry

use of org.openkilda.messaging.info.switches.LogicalPortInfoEntry in project open-kilda by telstra.

the class SwitchMapperTest method testToLogicalPortsValidationDto.

@Test
public void testToLogicalPortsValidationDto() {
    LogicalPortInfoEntry missing = LogicalPortInfoEntry.builder().logicalPortNumber(LOGICAL_PORT_NUMBER_1).type(LAG).physicalPorts(newArrayList(PHYSICAL_PORT_1, PHYSICAL_PORT_2)).build();
    LogicalPortInfoEntry excess = LogicalPortInfoEntry.builder().logicalPortNumber(LOGICAL_PORT_NUMBER_2).type(LAG).physicalPorts(newArrayList(PHYSICAL_PORT_3)).build();
    LogicalPortInfoEntry misconfigured = LogicalPortInfoEntry.builder().logicalPortNumber(LOGICAL_PORT_NUMBER_3).type(BFD).physicalPorts(newArrayList(PHYSICAL_PORT_4)).actual(new LogicalPortMisconfiguredInfoEntry(BFD, newArrayList(PHYSICAL_PORT_4))).expected(new LogicalPortMisconfiguredInfoEntry(LAG, newArrayList(PHYSICAL_PORT_4, PHYSICAL_PORT_5))).build();
    LogicalPortInfoEntry proper = LogicalPortInfoEntry.builder().logicalPortNumber(LOGICAL_PORT_NUMBER_4).type(LAG).physicalPorts(newArrayList(PHYSICAL_PORT_6)).build();
    LogicalPortsValidationEntry validationEntry = LogicalPortsValidationEntry.builder().missing(newArrayList(missing)).misconfigured(newArrayList(misconfigured)).proper(newArrayList(proper)).excess(newArrayList(excess)).build();
    LogicalPortsValidationDto validationDto = switchMapper.toLogicalPortsValidationDto(validationEntry);
    assertEquals(1, validationDto.getProper().size());
    assertEquals(1, validationDto.getMissing().size());
    assertEquals(1, validationDto.getMisconfigured().size());
    assertEquals(1, validationDto.getExcess().size());
    assertEqualsLogicalPortInfoDto(validationDto.getMissing().get(0), LOGICAL_PORT_NUMBER_1, LAG.toString(), PHYSICAL_PORT_1, PHYSICAL_PORT_2);
    assertEqualsLogicalPortInfoDto(validationDto.getExcess().get(0), LOGICAL_PORT_NUMBER_2, LAG.toString(), PHYSICAL_PORT_3);
    assertEqualsLogicalPortInfoDto(validationDto.getMisconfigured().get(0), LOGICAL_PORT_NUMBER_3, BFD.toString(), PHYSICAL_PORT_4);
    assertEqualsLogicalPortInfoDto(validationDto.getProper().get(0), LOGICAL_PORT_NUMBER_4, LAG.toString(), PHYSICAL_PORT_6);
    assertEquals(BFD.toString(), validationDto.getMisconfigured().get(0).getActual().getType());
    assertEquals(newArrayList(PHYSICAL_PORT_4), validationDto.getMisconfigured().get(0).getActual().getPhysicalPorts());
    assertEquals(LAG.toString(), validationDto.getMisconfigured().get(0).getExpected().getType());
    assertEquals(newArrayList(PHYSICAL_PORT_4, PHYSICAL_PORT_5), validationDto.getMisconfigured().get(0).getExpected().getPhysicalPorts());
}
Also used : LogicalPortInfoEntry(org.openkilda.messaging.info.switches.LogicalPortInfoEntry) LogicalPortMisconfiguredInfoEntry(org.openkilda.messaging.info.switches.LogicalPortMisconfiguredInfoEntry) LogicalPortsValidationDto(org.openkilda.northbound.dto.v1.switches.LogicalPortsValidationDto) LogicalPortsValidationEntry(org.openkilda.messaging.info.switches.LogicalPortsValidationEntry) Test(org.junit.Test)

Aggregations

LogicalPortInfoEntry (org.openkilda.messaging.info.switches.LogicalPortInfoEntry)8 Test (org.junit.Test)5 LogicalPortMisconfiguredInfoEntry (org.openkilda.messaging.info.switches.LogicalPortMisconfiguredInfoEntry)3 LogicalPort (org.openkilda.messaging.model.grpc.LogicalPort)3 LagLogicalPort (org.openkilda.model.LagLogicalPort)3 ArrayList (java.util.ArrayList)2 ValidateLogicalPortsResult (org.openkilda.wfm.topology.switchmanager.model.ValidateLogicalPortsResult)2 ValidationService (org.openkilda.wfm.topology.switchmanager.service.ValidationService)2 VisibleForTesting (com.google.common.annotations.VisibleForTesting)1 ImmutableList (com.google.common.collect.ImmutableList)1 ImmutableSet (com.google.common.collect.ImmutableSet)1 Sets (com.google.common.collect.Sets)1 String.format (java.lang.String.format)1 Arrays (java.util.Arrays)1 Collection (java.util.Collection)1 Collections (java.util.Collections)1 Comparator (java.util.Comparator)1 HashSet (java.util.HashSet)1 List (java.util.List)1 Map (java.util.Map)1